Opened 11 years ago

Closed 11 years ago

#5658 closed defect (invalid)

Win32 builds failing, starting at Revision 17696

Reported by: davidbuzz@… Owned by: danielk
Priority: critical Milestone: unknown
Component: windows Version: head
Severity: high Keywords:
Cc: Ticket locked: no

Description

It seems that the changes to "Convert MythSocket? to use a QThread instead of pthreads." (revision 17696) broke Win32/MINGW builds.

Initially it reported:

In file included from mythsocket.cpp:13: mythsocket.h:51: error: `HANDLE' does not name a type mythsocket.cpp: In member function `bool MythSocket::readStringList(QStringList&, bool)': mythsocket.cpp:440: warning: comparison between signed and unsigned integer expressions mythsocket.cpp: In member function `void MythSocketThread::ShutdownReadyReadThread?()': mythsocket.cpp:663: error: `readyreadevent' was not declared in this scope

but I aded a #include "compat.h" to the top of mythsocket.h and then I get the following errors that are beyond me:

cd libmythdb/ && make -f Makefile make[2]: Entering directory `/C/mythtv/mythtv/libs/libmythdb' g++ -c -march=k8 -g -Wall -Wno-switch -Wpointer-arith -Wredundant-decls -Wno-non-virtual-dtor -DST DC_CONSTANT_MACROS -frtti -fexceptions -mthreads -DQT_LARGEFILE_SUPPORT -DUSING_MINGW -DUSING_WINAUD IO -DUSING_D3D -DUSING_DIRECTX -DMMX -Di386 -DUSING_DIRECTX -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -DR UNPREFIX=\"..\" -DLIBDIRNAME=\"lib\" -DQT_THREAD_SUPPORT -DQT_DLL -DQT_SQL_LIB -DQT_GUI_LIB -DQT_NET WORK_LIB -DQT_CORE_LIB -I'../../../../msys/1.0/qt-win-opensource-src-4.4.0/include/QtCore' -I'../../ ../../msys/1.0/qt-win-opensource-src-4.4.0/include/QtCore' -I'../../../../msys/1.0/qt-win-opensource -src-4.4.0/include/QtNetwork' -I'../../../../msys/1.0/qt-win-opensource-src-4.4.0/include/QtNetwork'

-I'../../../../msys/1.0/qt-win-opensource-src-4.4.0/include/QtGui' -I'../../../../msys/1.0/qt-win-o

pensource-src-4.4.0/include/QtGui' -I'../../../../msys/1.0/qt-win-opensource-src-4.4.0/include/QtSql ' -I'../../../../msys/1.0/qt-win-opensource-src-4.4.0/include/QtSql' -I'../../../../msys/1.0/qt-win- opensource-src-4.4.0/include' -I'/C/mythtv/buildinclude' -I'c:/msys/1.0/qt-win-opensource-src-4.4. 0/include/ActiveQt' -I'.' -I'.' -I'../../../../MSys/1.0/qt-win-opensource-src-4.4.0/mkspecs/win32-g+ +' -o mythsocket.o mythsocket.cpp mythsocket.cpp: In member function `bool MythSocket::readStringList(QStringList&, bool)': mythsocket.cpp:440: warning: comparison between signed and unsigned integer expressions mythsocket.cpp: In member function `virtual void MythSocketThread::run()': mythsocket.cpp:810: warning: comparison between signed and unsigned integer expressions mythsocket.cpp:813: error: `Connected' was not declared in this scope mythsocket.cpp:813: warning: unused variable 'Connected' mythsocket.cpp:850: warning: comparison between signed and unsigned integer expressions mythsocket.cpp:864: error: `Connected' was not declared in this scope mythsocket.cpp:864: warning: unused variable 'Connected' mythsocket.cpp:773: warning: unused variable 'rfds' mythsocket.cpp:775: warning: unused variable 'maxfd' make[2]: * [mythsocket.o] Error 1

NOTE: I fully compiled builds 17689->17695, so I know that there is no issue there, the issue starts in 17696.

Change History (2)

comment:1 Changed 11 years ago by davidbuzz@…

sorry for the noise all, it appears this was already fixed by chris in 17735.

comment:2 Changed 11 years ago by paulh

Resolution: invalid
Status: newclosed
Note: See TracTickets for help on using tickets.