Opened 16 years ago
Closed 15 years ago
#5659 closed patch (fixed)
Add full path for XMLTV config file to database
Reported by: | Owned by: | stuartm | |
---|---|---|---|
Priority: | minor | Milestone: | 0.22 |
Component: | mythtv | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Changes:
libs/libmythtv/dbcheck.cpp: adds a new column to the videosource table which holds the full path to the XMLTV config file. For some reason, mythtv segfaults when upgrading the DB with this patch. Maybe someone can spot what's wrong, the BT seems useless to me.
libs/libmythtv/videosource.cpp: insert full path to the XMLTV config file when adding/modifying a video source
programs/mythfilldatabase/filldata.cpp: get full path to XMLTV config file from database. Fall back to old behavior if there's no entry.
This patch is not as well tested as I'd like it to be. It's posted for review. A version against trunk will be posted once the underlying logic has been approved.
Attachments (5)
Change History (15)
Changed 16 years ago by
Attachment: | xmltv_config_path_in_database.diff added |
---|
comment:1 Changed 16 years ago by
Milestone: | unknown → 0.21.1 |
---|---|
Owner: | changed from Isaac Richards to stuartm |
Status: | new → assigned |
comment:2 Changed 16 years ago by
Changed 16 years ago by
Attachment: | xmltv_config_path_fixes.diff added |
---|
comment:4 Changed 16 years ago by
Two new patches attached:
xmltv_config_path_fixes.diff:
Save the path to the config file in the settings table to avoid database schema updates in -fixes.
xmltv_config_path_trunk.diff:
Add configpath column to videosource table. Also add magic to dbcheck.cpp to carry over config file path from settings table.
Could use more testing. Committer takes all plane ;)
comment:5 Changed 16 years ago by
(In [18314]) Store the xmltv config file path in the database, this allows mythfilldatabase to be run by a different user to mythtv-setup, which helps out Ubuntu/Mythbuntu? packagers apparently. Patch by Michael Haas. Applying the -fixes version of the patch first since an Ubuntu deadline is close, trunk version will be reviewed and applied in a few hours. Refs #5659
comment:6 Changed 15 years ago by
Status: | assigned → infoneeded |
---|
The trunk patch needs some work, there are coding standards issues e.g. braces not on new lines, unused vars, code commented out and a comparison against an empty string where isEmpty() should be used instead.
It also needs updating for current trunk.
comment:7 Changed 15 years ago by
Milestone: | 0.21.1 → 0.22 |
---|---|
Version: | 0.21-fixes → head |
comment:8 Changed 15 years ago by
Resolution: | → invalid |
---|---|
Status: | infoneeded → closed |
info not provided
comment:9 Changed 15 years ago by
Resolution: | invalid |
---|---|
Status: | closed → new |
Updated patch against trunk attached.
comment:10 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [20980) Optionally read the full path to the xmltv configuration files from the database for the benefit of Ubuntu which runs mythfilldatabase under a different user to mythtv-setup or something. Patch from Michael Haas. Closes #5659
I think you need to terminate the updates[] array with a NULL like this