Wrong channel icon appears in Program Guide

[ylee@…]

I use the Retro theme on my 0.21-fixes system. If TV Settings|Program Guide|Display the channel icons is enabled, this theme displays the icon for the channel the program-selector box is on in the upper left-hand corner, as well as on the left edge of the screen along with icons for all the other channels currently displayed.

If TV Settings|Program Guide|Floating Program Guide Selector is disabled and Channels to Display is set to 6 (the default) or 7, the icon shown in the upper left-hand corner is, erroneously, for the channel above the currently-selected one. The screen looks something like this:

HGTVD  The Secret of Santa Vittoria
                                            Not Recording
(1969, 3 stars) Italian villagers unite to outwit . . .
ESPNHD Mike and Mike in the Morning
FOODHD Paid programming  Paid Programming  Paid Programming
HGTVD  Cash in the Attic  Look What I Did!  Weekend Warriors
MGMHD  [THE SECRET OF SANTA VITTORIA] Napoleon
UHD    Cobb
APLHD  The Planet's Funniest  Barking Mad  It's Me or the Dog
SCIHD  Megascience  Understanding  Beyond Invention

The correct channel icon appears in the corner if Channels to Display is set to 5 or 4. The bug does not trigger at all if Floating Program Guide Selector is enabled, or if Display the channel icons is disabled (i.e., the correct station ID is displayed in the corner).

[stuartm]

This bug has been around for years and I don't see any great reason to spend time on it at this late stage for 0.21. It should be fixed by the mythui port for 0.22.

[ylee@…]

Fixes incorrect icon in program guide under certain conditions in 0.21-fixes

[ylee@…]

Replying to stuartm:

This bug has been around for years and I don't see any great reason to spend time on it at this late stage for 0.21.

Understood. The bug annoyed me sufficiently, nonetheless, that I fixed it myself. The patch (against 0.21-fixes) is attached for the curious.