Opened 10 years ago

Closed 10 years ago

#5675 closed defect (fixed)

buttontemplate in MythUIButtonList::Init is always set, no checking required

Reported by: Erik Hovland <erik@…> Owned by: stuartm
Priority: trivial Milestone: 0.22
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

thanks to the magic of previous checks buttontemplate has to be valid. So the checks in Init() are not necessary (and are in fact unexecutable code).

Attachments (2)

libs_libmythui-deadcode.patch (1.1 KB) - added by Erik Hovland <erik@…> 10 years ago.
Removes unexecutable code
libs_libmythui-deadcode.2.patch (756 bytes) - added by Erik Hovland <erik@…> 10 years ago.
modified after ticket #5502 patch was properly changed

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by Erik Hovland <erik@…>

Removes unexecutable code

comment:1 Changed 10 years ago by stuartm

Milestone: unknown0.22
Owner: changed from Isaac Richards to stuartm
Status: newassigned

What version was this against? Although I see the first check in Init() (added in [18087]), the second doesn't appear in [18254].

comment:2 Changed 10 years ago by Erik Hovland <erik@…>

Dang monster patch set. The patch for ticket #5502 re-adds the check. Attached is the new patch w/out the second check. I am also going over to #5502 and submitting a new patch there.

Changed 10 years ago by Erik Hovland <erik@…>

modified after ticket #5502 patch was properly changed

comment:3 Changed 10 years ago by stuartm

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.