Opened 11 years ago

Closed 11 years ago

#5680 closed defect (fixed)

removal or fixing of dead code in libmyth

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: trivial Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

In mediamonitor-unix.cpp in AddDevice?, the pointer mep is never valid. So the recursive call will never happen.

In parseImageGrid in xmlparse.cpp there was a typo that caused the font2 pointer to be checked instead of the font3 pointer. That is fixed (but I also renamed the pointers so that they are more explicit about who they are).

Attachments (1)

libs_libmyth-deadcode.patch (2.5 KB) - added by Erik Hovland <erik@…> 11 years ago.
fixes a typo problem and removes some dead code.

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by Erik Hovland <erik@…>

Attachment: libs_libmyth-deadcode.patch added

fixes a typo problem and removes some dead code.

comment:1 Changed 11 years ago by Nigel

(In [18257]) Unused AddDevice?() method. Alerted to by patch from Erik Hovland. See #5680

comment:2 Changed 11 years ago by Nigel

Resolution: fixed
Status: newclosed

(In [18258]) Font-load error check fix, based on patch by Erik Hovland. Closes #5680

Note: See TracTickets for help on using tickets.