Opened 11 years ago

Closed 10 years ago

#5681 closed defect (invalid)

resubmission of libmythtv dead code patch

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: trivial Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

The top of this patch is the most interesting. The first in startPlaying - I expand the commented out code since the meat of the code is already commented out. The idea is that it shouldn't have to do that preparation code since it won't be used.

Then in DisplayDVDButton the if clause after the subtitles call is a little wonky. The second check of osdshown is unnecessary.

The next interesting bit is the unnecessary assignment in dsmc.cpp in ProcessSection?. Everything else has been seen before. But they all are related to code that cannot execute.

Attachments (1)

libs_libmythtv-dead-code.patch (7.8 KB) - added by Erik Hovland <erik@…> 11 years ago.
Remove or fix code that cannot execute in libmythtv

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by Erik Hovland <erik@…>

Remove or fix code that cannot execute in libmythtv

comment:1 Changed 10 years ago by Erik Hovland <erik@…>

Please close this ticket.

comment:2 Changed 10 years ago by paulh

Resolution: invalid
Status: newclosed

Closed at the request of the OP.

Note: See TracTickets for help on using tickets.