Opened 11 years ago

Closed 11 years ago

#5691 closed defect (fixed)

Uninitialized variables and member variables in mythbackend

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: trivial Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

AutoExpire? and ProcessRequestThread? have ctors that need initializing.

SchedPreserveLiveTV uses a static member function of ProgramInfo? but uses a pointer variable to access it. It would be more readable if it used the class scoping instead.

Attachments (1)

programs_mythbackend-uninit.patch (2.2 KB) - added by Erik Hovland <erik@…> 11 years ago.
init meber vars in ctors and use class scoping

Download all attachments as: .zip

Change History (2)

Changed 11 years ago by Erik Hovland <erik@…>

init meber vars in ctors and use class scoping

comment:1 Changed 11 years ago by Nigel

Resolution: fixed
Status: newclosed

(In [18299]) Xtor and method call tidy up. Patch from Erik Hovland. Closes #5691. Note that I didn't apply the AutoExpire? xtor change, because update_thread is only used internally in AutoExpire::Update(), and expire_thread is only accessed if expire_thread_running is true, which happens in the other xtor.

Note: See TracTickets for help on using tickets.