Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#5698 closed defect (fixed)

defects in mythgallery

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: trivial Milestone: unknown
Component: mythgallery Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

GLSingleView::paintGL could use a pointer validity check on the pointer variable item.

FileCopyThread? ctor needs to initialize some variables.

SingleView::paintEvent could use a pointer validity check on the pointer variable item.

Attachments (1)

mythgallery-defects.patch (2.3 KB) - added by Erik Hovland <erik@…> 11 years ago.
fixes some defects in mythgallery

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by Erik Hovland <erik@…>

Attachment: mythgallery-defects.patch added

fixes some defects in mythgallery

comment:1 Changed 11 years ago by paulh

Resolution: fixed
Status: newclosed

(In [18302]) Initialize a variable in FileCopyThread?'s ctor. Fixes #5698

comment:2 Changed 11 years ago by paulh

Those checks for item need to be placed a little earlier in the code since in both cases item is dereferenced a couple of lines before the check you put in. Doh! :-)

Anyway the singleview and glsingleview screens will both be removed when they are combined into a single screen supporting both Qt and GL as part of the switch to mythui so there's no need to fix it. Thanks anyway.

Note: See TracTickets for help on using tickets.