Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#5759 closed defect (fixed)

Recording Priorities should be renamed to Recording Rules

Reported by: ylee@… Owned by: sphery
Priority: minor Milestone: 0.22
Component: mythtv Version: head
Severity: medium Keywords: menu theme recording rules priorities
Cc: Ticket locked: no

Description

The mythfrontend page "Program Recording Priorities" is misleadingly labeled. It is the only place on mythfrontend guaranteed to list all current recording rules, whether active or inactive, standard or custom. Because its menu entry is "Recording Priorities" (or "Set Priorities" depending on the menu theme) many users don't realize this, however, and thus ask how to review their rules or delete a custom rule.

I suggest that the page be renamed "Program Recording Rules" or "Recording Rules," with appropriate changes to the menu themes.

Attachments (5)

mythtv-5759-add_support_for_manage_rules.patch (29.0 KB) - added by sphery <mtdean@…> 11 years ago.
Add a new screen for managing recording rules
mythtv-5759-add_support_for_manage_rules.2.patch (29.3 KB) - added by sphery <mtdean@…> 11 years ago.
Updated for recent changes in trunk
mythtv-5759-add_support_for_manage_rules.3.patch (29.2 KB) - added by sphery <mtdean@…> 10 years ago.
Updated patch--accounts for the move of manage_recordings.xml to themes/defaultmenu
mythtv-5759-add_support_for_manage_rules.4.patch (29.9 KB) - added by sphery <mtdean@…> 10 years ago.
Updated patch for recent changes to trunk
mythtv-5759-add_support_for_manage_rules.5.patch (30.4 KB) - added by sphery <mtdean@…> 10 years ago.
Updated patch, uses constructor to pass the object name and uses object name to determine which window to load.

Download all attachments as: .zip

Change History (13)

Changed 11 years ago by sphery <mtdean@…>

Add a new screen for managing recording rules

comment:1 Changed 11 years ago by sphery <mtdean@…>

Rather than rename the "Set Priorities" screen--that was designed explicitly for setting priorities of recording rules and really only displays priority-related information about the rules--it makes more sense to add a screen that allows for managing recording rules while presenting information that makes it easier to decide which rules to edit/cancel.

The attached patch, mythtv-5759-add_support_for_manage_rules.patch , adds a new screen "Manage Recording Rules" by modifying programrecpriorities.{h,cpp} to allow showing any of many fields that previously could not be displayed on the "Set Priorities" screen. It also adds a new window definition to default{,-wide}/schedule-ui.xml to show a less-priority-centric view of the recording rules with useful information for deciding which to edit.

I edited the default and classic menu themes to include the new screen (with the button label "Recording Rules"), but did not add the screen to the DVR menu layout as it didn't really fit well in any of the menus and anyone who's using the DVR theme probably already realizes that he/sh can use the Set Priorities screen to see a list of all recording rules so he/she can jump to the scheduled recording editor to edit/cancel the rule. I also moved the "Set Priorities" menu item to the end of the "Manage Recordings" menu and placed "Recording Rules" second on the screen (where "Set Priorities" was) as it seems a more commonly-useful screen.

There's currently no watermark image for "Recording Rules".

Also, because all of the same functionality and information is available through both screens, menu themers can choose whether to include both windows or just one in their themes. The only difference between the two screens is which window is displayed (i.e. which information is presented to the user).

If there are other fields that should be made available on the Manage Recording Rules screen, please let me know and I'll add them.

comment:2 Changed 11 years ago by stuartm

Milestone: unknown0.22
Owner: changed from Isaac Richards to stuartm
Status: newaccepted
Version: unknownhead

Changed 11 years ago by sphery <mtdean@…>

Updated for recent changes in trunk

Changed 10 years ago by sphery <mtdean@…>

Updated patch--accounts for the move of manage_recordings.xml to themes/defaultmenu

Changed 10 years ago by sphery <mtdean@…>

Updated patch for recent changes to trunk

comment:3 Changed 10 years ago by stuartm

Status: acceptedinfoneeded

Sphery, can you pass the window name in through the constructor rather than as a parameter of Create()?

Changed 10 years ago by sphery <mtdean@…>

Updated patch, uses constructor to pass the object name and uses object name to determine which window to load.

comment:4 Changed 10 years ago by sphery <mtdean@…>

Updated patch added. Passes the object name to the constructor and uses the object name to determine which window to load (since the theme's window name is all lower case versus the object name, which has capital letters at word boundaries).

comment:5 Changed 10 years ago by stuartm

Status: infoneededassigned

comment:6 Changed 10 years ago by stuartm

Owner: changed from stuartm to sphery

comment:7 Changed 10 years ago by sphery

Resolution: fixed
Status: assignedclosed

(In [21380]) Add a new, "Recording Rules," screen under the "Manage Recordings."

Like "Set Priorities," "Recording Rules" lists all recording rules--even those that don't match any episodes in the current listings. However, "Recording Rules" presents additional information beyond just priorities that may be useful in managing recording rules (such as Last Recorded date, Recording Group, and more), and the name is closer to what someone wanting to delete or edit recording rules would be expecting rather than, "Set Priorities."

Menu themers can choose to include either or both "Recording Rules" and "Set Priorities." This change adds the "Recording Rules" screen to the default and classic menu themes, but does not add it to the DVR menu theme. There is also a window definition provided in both the default and default-wide themes.

Fixes #5759

comment:8 Changed 10 years ago by sphery

(In [21412]) Fix the Recording Rules screen to use shapes rather than the old image-based background and lines. Refs #5759

Note: See TracTickets for help on using tickets.