Opened 16 years ago

Closed 15 years ago

#5774 closed defect (fixed)

class Credentials in libmythdb could use explicit on its ctor

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: trivial Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Since both parameters of the ctor are given default values, it makes sense to mark the ctor explicit so there are no implicit uses of the class.

Attachments (1)

libs_libmythdb-krazy2-explicit-ctor.patch​ (882 bytes) - added by Erik Hovland <erik@…> 16 years ago.
Adds explicit keyword to Credentials ctor

Download all attachments as: .zip

Change History (2)

Changed 16 years ago by Erik Hovland <erik@…>

Attachment: libs_libmythdb-krazy2-explicit-ctor.patch​ added

Adds explicit keyword to Credentials ctor

comment:1 Changed 15 years ago by danielk

Resolution: → fixed
Status: new → closed

(In [19433]) Fixes #5774. Adds explicit keyword for HttpComms::Credentials class. This 'efficiency bug' is not really something I'd worry about, but I wanted to clean up the constructor anyway.

Note: See TracTickets for help on using tickets.