Opened 15 years ago

Closed 15 years ago

#5778 closed defect (wontfix)

#define for values in C++ in libmythdb

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: trivial Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Using #define in C++ defeats the strict type checking the language provides when used with values. Replacing those macros with const values would provide that type checking.

Attachments (1)

libs_libmythdb-krazy2-replace-define.patch​ (3.3 KB) - added by Erik Hovland <erik@…> 15 years ago.
Replaces #define values with const values in libmythdb

Download all attachments as: .zip

Change History (2)

Changed 15 years ago by Erik Hovland <erik@…>

Attachment: libs_libmythdb-krazy2-replace-define.patch​ added

Replaces #define values with const values in libmythdb

comment:1 Changed 15 years ago by danielk

Resolution: → wontfix
Status: new → closed

really? :) There is actually a reason for all those defines, mostly that they are outside code that we've imported into MythTV and don't want to diverge too far from upstream.

Note: See TracTickets for help on using tickets.