Opened 11 years ago

Closed 10 years ago

#5779 closed defect (wontfix)

#include directive cleaning in libmythdb

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: trivial Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Header guards (#ifndef/#define/#endif) could do w/out any underscore before or after the macro. The guard macro should match the file name. And any .cpp should have its corresponding header file listed first.

Attachments (1)

libs_libmythdb-krazy2-include-directives.patch (14.2 KB) - added by Erik Hovland <erik@…> 11 years ago.
Addresses include directive defects

Download all attachments as: .zip

Change History (2)

Changed 11 years ago by Erik Hovland <erik@…>

Addresses include directive defects

comment:1 Changed 10 years ago by danielk

Resolution: wontfix
Status: newclosed

Way too pedantic! Also a single underscore for the start of header defines is good for avoiding any name collisions.

Note: See TracTickets for help on using tickets.