Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#578 closed patch (fixed)

Patch to hide main window on os x when we are not playing video in the main window.

Reported by: gkruse@… Owned by: Nigel
Priority: minor Milestone: 0.19
Component: mythtv Version: head
Severity: medium Keywords: os x hide main window playback
Cc: Ticket locked: no

Description

On os x it is possible to play video in a floating window, the dock or the desktop, and not play video in the main window. When there is no video in the main window, it is just black and in the way of everything else. There is no way to minimize this window. This patch "hides" the main window by making it 1x1 when playback is started. When playback is stopped, the main window is restored to its original size. I chose to make the window 1x1 instead of hiding it, because in order to receive keystrokes, the main window cannot be hidden. This is my first attempt at a patch to the actual code of myth, please let me know everything I did wrong so I can fix it in the future.

Attachments (1)

osxWindowHide.patch (2.1 KB) - added by gkruse@… 14 years ago.
patch to hide main window on playback

Download all attachments as: .zip

Change History (5)

Changed 14 years ago by gkruse@…

Attachment: osxWindowHide.patch added

patch to hide main window on playback

comment:1 Changed 14 years ago by Nigel

Status: newassigned

I still have to do some more testing, but this looks good.

comment:2 Changed 13 years ago by Nigel

Resolution: fixed
Status: assignedclosed

There was already a variable that stored the window dimensions, so I changed the scope of that and used it instead of adding another one (whose declaration wasn't in the Geoff's patch).

comment:3 Changed 13 years ago by Nigel

(In [8043]) Geoffrey Kruse's "hide main window during other output types" patch. See #578

comment:4 Changed 13 years ago by Nigel

I said the declaration of the variable wasn't in Geoff's patch. That is wrong, it just was in a different place to all the other private variables!

Note: See TracTickets for help on using tickets.