Opened 11 years ago

Closed 11 years ago

#5791 closed patch (fixed)

Allow time zone ID's whose to differ by space/underscore

Reported by: sphery <mtdean@…> Owned by: Janne Grunau
Priority: minor Milestone: 0.22
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The attached patch modifies the time zone ID check to allow zone ID's whose only difference is the substitution of a space for an underscore. It seems that some distros' time zone configuration tools write the zone ID to the configuration with spaces rather than underscores.

The patch creates new QStrings for the comparison rather than modifying the originals. With this approach, if we allow the zone ID's, but find a discrepancy in the UTC offset or the current time, the error message will actually show that the zone ID's we retrieved differ. This should help encourage users to also check their zone definitions/time zone configuration (whereas if we falsely output the same zone ID for master and local, they may assume they don't need to verify the time zone settings).

In the meantime, users wanting to work around the issue can likely fix the problem by starting the system whose zone ID is identified with a space using:

TZ='America/New_York' mythfrontend

for example. Note that this assumes the actual zoneinfo database files do not have spaces--as should be the case. If the above causes UTC offset to differ, copy the appropriate zone info file to a file whose name uses underscores instead of spaces. For example:

cp /usr/share/zoneinfo/America/New\ York /usr/share/zoneinfo/America/New_York

Attachments (1)

mythtv-5791-allow_space_or_underscore_in_zone_id.patch (1.1 KB) - added by sphery <mtdean@…> 11 years ago.

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by sphery <mtdean@…>

comment:1 Changed 11 years ago by Janne Grunau

Milestone: unknown0.22
Owner: changed from Isaac Richards to Janne Grunau
Status: newaccepted

comment:2 Changed 11 years ago by Janne Grunau

Resolution: fixed
Status: acceptedclosed

fixed by [18587]

Note: See TracTickets for help on using tickets.