Patch for 'filemarkup table is inefficient'

[simonwalls@…]

This is 'the start' of a patch for the minor issue in Ticket #5109 with the filemarkup table containing the full pathname of the file for every single mark. Particularly when MARK_GOP_BYFRAME is in use, eg. for mpeg-2's, there are many thousands of marks for a movie file.

This patch changes the usage of filemarkup.filename to be the intid of the video (as found in videometadata.intid). It is against 0.21-fixes SVN 17450.

It does not purport to be complete and suitable for inclusion, since to do it properly, a field name change would be required in the database schema (filemarkup.filename -> filemarkup.intid) complete with upgrade of the schema number etc etc in the appropriate file(s) eg. mythvideo/dbcheck.cpp. It might be the case, although I don't think so at this time, that some other plugins require changes.

However, the basics work despite those limitations and is in use on my main system. I'm raising the ticket to get the patch recorded and available to others, particularly the original submitter of Ticket #5109.

When I have more time, I can look at ensuring this patch is complete (all other plugins do or don't require mods) and then including the date of last rebuild of filemarkup in the videometadata table, to aid the other latent problem I wrote of in Ticket #5109.

My database went from 63Mb to 74Mb with 33 mpeg2 files (including 12 movies) added to the filemarkup table (162,000 rows in table). Without the patch an almost identical size increase occurred with only 3 movies indexed.

A script to rebuild the seektables of all .mpg videos using mythtranscode (with mpeg2 option) is included. (The original contents of filemarkup are not dropped, they are retained in the table but will not be found, since the access to the filemarkup table now looks for the numeric 'intid' from the videometadata table, in that column).

[simonwalls@…]

Patch to 0.21-fixes SVN 17450 to improve efficiency of filemarkup table

[simonwalls@…]

Shell script to run mythtranscode for all .mpg files in a directory to rebuild their seektables (using --mpeg2 option)

[simonwalls@…]

Improved patch to 0.21-fixes SVN 17450

[simonwalls@…]

Commented out the debug-output statements

[cpinkham]

The conversion from filename -> int will be done as part of some larger changes post-0.22, so I'm changing the milestone for this ticket.

[cpinkham]

Moving some things to 0.24 since we're almost at the 0.23 feature freeze.

[robertm]

Moving to general since it pertains more directly to the DB schema updates Chris has pending at this point.

[cpinkham]

This feature will be accomplished as part of a larger file and seek table database reorg that is in the works. There is no need to keep this ticket open so I'm closing it to help cleanup Trac. Marking ticket as 'duplicate' even though it's not because it's not really a "won't fix" or any other category.