Opened 11 years ago

Closed 11 years ago

#5875 closed defect (fixed)

MythWeather setup segfaults

Reported by: otto at kolsi dot fi Owned by: stuartm
Priority: minor Milestone: 0.22
Component: mythweather Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

MythWeather? setup segfaults when trying to setup screens:

  • go to MythWeather? Screen settings
  • select Current Conditions with Enter
  • select "SI Units" from the popup (English Units segfaults also)
  • Segfault

This is with MythCenter?, backtrace is attached.

Attachments (6)

MythWeather-Setup-Backtrace.txt (12.5 KB) - added by otto at kolsi dot fi 11 years ago.
mythui_mythweather.diff (2.0 KB) - added by stuartm 11 years ago.
Potential fix
mythui_mythweather.2.diff (2.1 KB) - added by Marc Alban <marcalban@…> 11 years ago.
This is based on the patch from stuartm, but adds the missing qVariantFromValue() calls and prevents a segfault when escaping from the units popup.
mythui_mythweather.3.diff (2.5 KB) - added by Marc Alban <marcalban@…> 11 years ago.
forgot Q_DECLARE_METATYPE
mythui_mythweather.4.diff (10.2 KB) - added by Marc Alban <marcalban@…> 11 years ago.
This patch includes the previous seg fault fixes along with several more.
mythui_mythweather.5.diff (11.9 KB) - added by Marc Alban <marcalban@…> 11 years ago.
Included a few more fixes to mythweather.

Download all attachments as: .zip

Change History (11)

Changed 11 years ago by otto at kolsi dot fi

Changed 11 years ago by stuartm

Attachment: mythui_mythweather.diff added

Potential fix

comment:1 Changed 11 years ago by stuartm

Milestone: unknown0.22
Status: newaccepted

Attached a patch, please test and let me know if it fixes the issue for you. Requires [19074]

Changed 11 years ago by Marc Alban <marcalban@…>

Attachment: mythui_mythweather.2.diff added

This is based on the patch from stuartm, but adds the missing qVariantFromValue() calls and prevents a segfault when escaping from the units popup.

Changed 11 years ago by Marc Alban <marcalban@…>

Attachment: mythui_mythweather.3.diff added

forgot Q_DECLARE_METATYPE

comment:2 Changed 11 years ago by otto at kolsi dot fi

Just tested the patches. The original patch still causes segfault, the latest attached mythui_mythweather.3.diff seems to fix the problem.

Changed 11 years ago by Marc Alban <marcalban@…>

Attachment: mythui_mythweather.4.diff added

This patch includes the previous seg fault fixes along with several more.

comment:3 Changed 11 years ago by Marc Alban <marcalban@…>

mythui_mythweather.4.diff addresses the original seg fault and the following issues I noticed.

1) Seg fault when trying to move to next or previous screen when no screens have been defined.

2) Seg fault when manipulating the spinners in the sources setup page when no sources have been defined.

3) Seg fault when clicking on a location returned from a search.

4) Seg fault when attempting to remove a screen in screen setup page.

5) Seg fault when attempting to change a location in screen setup page.

6) Seg fault when attempting to change units in screen setup page.

Additionally, When no weather screens have been defined, selecting weather in the information screen brings up the weather screen setup page. For me at least, the setup page is covered by the empty weather info page. This patch ensures that the setup page is drawn on top by adding it to the screen stack after the info page instead of before.

Changed 11 years ago by Marc Alban <marcalban@…>

Attachment: mythui_mythweather.5.diff added

Included a few more fixes to mythweather.

comment:4 Changed 11 years ago by Marc Alban <marcalban@…>

mythui_mythweather.5 adds fixes for a few more issues.

1) Pressing 'menu' in the weather info screen would display the setup screen and the weather data at the same time all mixed up. A seg fault would then occur on user input.

2) Changing the weather screens by pushing left or right in the info page would toggle the pause state.

comment:5 Changed 11 years ago by stuartm

Resolution: fixed
Status: acceptedclosed

(In [19105]) Few fixes to mythweather from Marc Alban. Majority of these were segfaults relating to the switch from void* to QVariant storage in MythUIButtonList and MythDialogBox?. Rest are improvements to behaviour. Closes #5875

Note: See TracTickets for help on using tickets.