Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#589 closed defect (fixed)

OSD menu in wrong position with [7733]

Reported by: kkuphal Owned by: danielk
Priority: minor Milestone: 0.19
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

I updated to [7733] tonight and my OSD menu is now slight off the screen to the left where before it was properly centered just to the right of the left side of the screen. I'd say it is off the left side of the screen by maybe 10 pixels or so. I can certainly still read the text but it isn't right.

Change History (4)

comment:1 Changed 14 years ago by kkuphal

On further investigation, I have vertical and horizontal adjust percentages (2 and 4% respectively) set in the Playback options. Upon removing those, the OSD is properly centered again. This didn't seem to be the behavior in previous revisions (moving the OSD as opposed to adjusting only the picture). Also, not just the OSD menu was adjusted, I now note that the OSD progress bar was moved as well.

comment:2 Changed 14 years ago by danielk

Owner: changed from Isaac Richards to danielk

comment:3 Changed 14 years ago by danielk

Resolution: fixed
Status: newclosed

(In [7786]) Fix #589.

AFAIC we've never accounted for overscan in OSD placement, but the x & y for the upper right corner of the OSD visible size were transposed in the NVP after a recent change so that made the adjustments we do make for letterboxing modes completely bogus for any of the zooming modes.

In addition to the fix for the regression, I've also made GetVisibleOSDBounds() calculate the visible screen based on the params set by MoveResize?(), which should prevent it for getting out of sync with MoveResize? as it did with respect to the 16/9 Zoom and 16/9 Stretch letterboxing modes.

comment:4 Changed 14 years ago by danielk

(In [7797]) References #589.

I accidentally committed the NVR instead of the NVP in [7786].

The change in NVR just supresses a runtime warning message when it is not appropriate.

Note: See TracTickets for help on using tickets.