Opened 11 years ago

Closed 8 years ago

#5911 closed Patch - Bug Fix (fixed)

mythmusic: Fix goom mmxext for amd64

Reported by: foobum@… Owned by: paulh
Priority: trivial Milestone: 0.25
Component: Plugin - MythMusic Version: Unspecified
Severity: low Keywords: goom amd64
Cc: Ticket locked: no

Description

The mmxext zoom filter in goom was disabled on amd64, presumably because it didn't compile. This small patch fixes the problem and enables the mmxext filter on amd64.

Attachments (4)

goom-mmxext-amd64-fix.patch (1.8 KB) - added by foobum@… 11 years ago.
goom-sse2.patch (7.7 KB) - added by foobum@… 11 years ago.
goom-sse2-1.patch (8.5 KB) - added by foobum@… 11 years ago.
goom-simd.patch (11.1 KB) - added by foobum@… 11 years ago.

Download all attachments as: .zip

Change History (11)

Changed 11 years ago by foobum@…

Attachment: goom-mmxext-amd64-fix.patch added

Changed 11 years ago by foobum@…

Attachment: goom-sse2.patch added

comment:1 Changed 11 years ago by foobum@…

Turns out that the mmxext code is slower than the mmx on amd64. To make up for it, here's a SSE2 implementation that is ~ 10-20% faster than the mmx (on amd64). Not sure about ia32 - could someone test?

Also lowers the fps for goom a touch since it was excessively cpu hungry.

Changed 11 years ago by foobum@…

Attachment: goom-sse2-1.patch added

comment:2 Changed 11 years ago by foobum@…

New version - forgot to change .pro

Changed 11 years ago by foobum@…

Attachment: goom-simd.patch added

comment:3 Changed 11 years ago by foobum@…

New version that combines the previous patches, improves the asm and makes it x86 compatible. Now significantly faster on am64 and ~ 33% faster (than the previous fastest method) on x86. Tested on both archs.

comment:4 Changed 10 years ago by stuartm

Component: mythmusicPlugin - MythMusic

comment:5 Changed 9 years ago by danielk

Owner: changed from Isaac Richards to paulh
Status: newassigned

Paul, I've been told you are working on MythMusic...

comment:6 Changed 8 years ago by stuartm

Milestone: unknown0.25
Type: patchPatch - Bug Fix
Version: unknownUnspecified

comment:7 Changed 8 years ago by Github

Resolution: fixed
Status: assignedclosed

MythMusic: add faster zoom filter in goom that uses sse2 when available.

Fixes #5911.

Signed-off-by: Paul Harrison <pharrison@…>

Branch: master Changeset: c9fc987fe97590c0ce69905a43a3d63cd9ecb0e3

Note: See TracTickets for help on using tickets.