Opened 11 years ago

Closed 11 years ago

#5922 closed patch (fixed)

fix finnish rerun detection

Reported by: ikke@… Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.22
Component: eit Version: 0.21-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Finnish re-run detection is broken. This patch originally done by tomi.orava@… bases on a "rule" that re-runs are marked having string "Uusinta .*" or Just "U" at the end. In english it's "Rerun" and "R". Sometimes it is marked like "Rerun from last week" or something, thats why regexp matches more than just "Uusinta".

I'll attach patch here. Also for the finnish users, I add here the cronscript that takes of the same stuff from xmltv fetched data. That includes crontab entry and a script.

Patch is against 21-fixes.

Attachments (5)

myth-eitfix-fi.patch (2.3 KB) - added by ikke@… 11 years ago.
the patch against 21-fixes
mythfilldatabase_cleanup.sh (1.3 KB) - added by ikke@… 11 years ago.
script getting xmltv data and removing rerun marks
myth-eitfix-fi-netwid-fixed.patch (2.1 KB) - added by ikke@… 11 years ago.
patch with network ids with a number other than zero
network-ids-welho.txt (13.9 KB) - added by ikke@… 11 years ago.
welho channel and dvb multiplex tables to show patch numbers are ok
myth-eitfix-fi-2.patch (2.1 KB) - added by ikke@… 11 years ago.
One more change, additional blank removing added.

Download all attachments as: .zip

Change History (17)

Changed 11 years ago by ikke@…

Attachment: myth-eitfix-fi.patch added

the patch against 21-fixes

Changed 11 years ago by ikke@…

Attachment: mythfilldatabase_cleanup.sh added

script getting xmltv data and removing rerun marks

comment:1 in reply to:  description Changed 11 years ago by anonymous

I forgot to mention that I've been succesfully running this for a month now. It fixes the problem of mythtv recording same shows multiple times because description of the show episode differs due to "rerun" words in there.

Track did not accept cronjob file as attachement, but here's the line from /etc/cron.daily/mythfilldatabase:

sudo -u mythtv -H /stuff/videot/mythtv/.mythtv/mythfilldatabase_cleanup.sh --fetch --feed

comment:2 Changed 11 years ago by danielk

Component: mythtveit
Owner: changed from Isaac Richards to Stuart Auchterlonie

comment:3 Changed 11 years ago by Stuart Auchterlonie

Milestone: unknown0.22
Status: newinfoneeded_new

The bulk of this patch is fine. However i'm not happy with putting a fixup in that is only keyed off NetworkID=0.

This is known to be used by numerous buggy providers, so we cannot use it without qualifying it some more.

This part needs updating

DVB-C Elisa Finland fix[ 0U << 16] = EITFixUp::kFixFI;

to include transportid and serviceid.

comment:4 in reply to:  3 Changed 11 years ago by Janne Grunau

Status: infoneeded_newnew

Replying to stuarta:

The bulk of this patch is fine. However i'm not happy with putting a fixup in that is only keyed off NetworkID=0.

This is known to be used by numerous buggy providers,

it is only used by buggy providers, the DVB standard doesn't allow that value.

DVB-C Elisa Finland fix[ 0U << 16] = EITFixUp::kFixFI;

to include transportid and serviceid.

I'm not sure if it's a good idea to have one fixup for every channel on that network. It doesn't ensure unique id's. I assume that it's common for buggy providers that the transport and service ids start at 0 too.

If the other ids look rather random it is still a bad idea since we have to udate the fixups for every channel change on the network.

I would say we can't unfortunately do fixups on broken networks.

comment:5 Changed 11 years ago by ikke@…

Hi,

thanks for your attention. That network id is my bad, I have that. It was forgotten there, since I and my friend has different network ids so we just did not set it. Mine is 42249.

In Finland we have a set of channels that are open for everyone, about <10 of those. Those channels are delivered via local DVB-C operators and a national DVB-T provider (many network ids). But all networks have the same eit info, and the same xmltv source for that. The patch now works for all Finns now, and too bad it would run for all others as well ). I totally understand your point of narrowing down the amount of networks that the patch applies to.

I try to ask some friends to check their network id's. Anyone interested, do this:

$ mysql -u mythtv -pmythtv mythconverg mysql> select callsign,name,mplexid,serviceid from channel order by mplexid; mysql> select mplexid,transportid,networkid from dtv_multiplex;

Check network id for Finnish channels from the last command, the channels are mapped to mplexid from the first mysql output.

We would be interested of adding the major ones at least. My provider is Welho (ex HTV in capital area, 42249). National Yle would be interesting, and perhaps Elisa from the biggest DVB-C providers at least.

Of course the Welho info page has the wrong networkid there...

comment:6 Changed 11 years ago by ikke@…

sorry, forgot line breaks for mysql commands, let's try again:

$ mysql -u mythtv -pmythtv mythconverg
mysql> select callsign,name,mplexid,serviceid from channel order by mplexid;
mysql> select mplexid,transportid,networkid from dtv_multiplex;

comment:7 Changed 11 years ago by anonymous

OK, I got more info about some providers. Finnish national YLE dvb-t broadcasts have networkid 8438 at least in southern Finland, capital area:

{{{ DVB-T Espoo, Finland

fix[ 8438U << 16] = EITFixUp::kFixFI;

DVB-C Elisa Finland fix[ 0U << 16] = EITFixUp::kFixFI; fix[ 15U << 16] = EITFixUp::kFixFI;

}}}

The latter one, Elisa, is the kind you mentioned, one with bad networkid zero. Let's forget that one, everyone can patch it themselves who need it.

So all together, could you please add DVB-T YLE id 8438 and DVB-C Welho id 42249 for Finnish fixup call?

{{{ DVB-T Espoo, Finland

fix[ 8438U << 16] = EITFixUp::kFixFI; DVB-C Welho, Finland fix[ 42249U << 16] = EITFixUp::kFixFI;

}}}

Changed 11 years ago by ikke@…

patch with network ids with a number other than zero

Changed 11 years ago by ikke@…

Attachment: network-ids-welho.txt added

welho channel and dvb multiplex tables to show patch numbers are ok

comment:8 Changed 11 years ago by ikke@…

I just updated my mythtv, and while compiling I created a new version of the patch. This has now the broken Elisa network removed. I dumped my tables also so Janne can decide wether ids are too random.

comment:9 Changed 11 years ago by Stuart Auchterlonie

Status: newinfoneeded_new

It's not clean from the myth-eitfix-fi-netwid-fixed.patch which fixup reference relates to the now removed Elisa network. If it was i would remove that portion of the patch and commit it

Can you update this to reflect what is currently being broadcast?

Stuart

comment:10 Changed 11 years ago by ikke@…

You don't need to modify the second patch (myth-eitfix-fi-netwid-fixed.patch) at all, I removed the Elisa for you and this is the result.

If you compare the patches you see the difference. I just completely removed the Elisa from the second patch. Otherwise they are identical.

Changed 11 years ago by ikke@…

Attachment: myth-eitfix-fi-2.patch added

One more change, additional blank removing added.

comment:11 Changed 11 years ago by ikke@…

stuarta, we chatted today, and I told the patch can be applied as such. But I added one blank character into regexp. This is still OK to apply as such. I just compiled it against 20249 version of fixes and it compiled fine.

comment:12 Changed 11 years ago by Stuart Auchterlonie

Resolution: fixed
Status: infoneeded_newclosed

(In [20261]) Closes #5922. EITFixup for Finnish re-run detection.

Thanks to ikke for the patch.

Note: See TracTickets for help on using tickets.