Opened 11 years ago

Closed 11 years ago

#5935 closed patch (fixed)

mythshutdown --help

Reported by: Matthew Wire <devel@…> Owned by: danielk
Priority: minor Milestone: 0.22
Component: mythshutdown Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

There is no need to initialise mythcontext or anything when running mythshutdown --help. This patch simply moves the call for showUsage() higher up so it is called before initialisation.

Without this it is impossible to see usage message without being able to connect to a backend.

Attachments (11)

08-mythshutdown-showusage.patch (820 bytes) - added by Matthew Wire <devel@…> 11 years ago.
10-mythwelcome-showusage.patch (1.4 KB) - added by Matthew Wire <devel@…> 11 years ago.
The same for mythwelcome
main.cpp (25.7 KB) - added by Matthew Wire <devel@…> 11 years ago.
20-5935-mythshutdown-showusage.patch (8.4 KB) - added by Matthew Wire <devel@…> 11 years ago.
Updated patch
00-5935-mythwelcome-showusage.patch (4.0 KB) - added by Matthew Wire <devel@…> 11 years ago.
00-5935-mythfrontend-showusage.patch (1.5 KB) - added by Matthew Wire <devel@…> 11 years ago.
00-5935-mythbackend-showusage.patch (6.1 KB) - added by Matthew Wire <devel@…> 11 years ago.
20-5935-mythshutdown-showusage.2.patch (7.7 KB) - added by Matthew Wire <devel@…> 11 years ago.
Minor compile fixes due to header reorganisation
00-5935-mythbackend-showusage.2.patch (6.1 KB) - added by Matthew Wire <devel@…> 11 years ago.
00-5935-mythfrontend-showusage.2.patch (2.0 KB) - added by Matthew Wire <devel@…> 11 years ago.
00-5935-mythwelcome-showusage.2.patch (4.0 KB) - added by Matthew Wire <devel@…> 11 years ago.

Download all attachments as: .zip

Change History (17)

Changed 11 years ago by Matthew Wire <devel@…>

Changed 11 years ago by Matthew Wire <devel@…>

The same for mythwelcome

Changed 11 years ago by Matthew Wire <devel@…>

Attachment: main.cpp added

Changed 11 years ago by Matthew Wire <devel@…>

Updated patch

comment:1 Changed 11 years ago by Matthew Wire <devel@…>

20-5935-mythshutdown-showusage.patch
Updated version of previous patch:
-Adds version info to usage printout.
-Changes calls from "system" to "myth_system" instead.
-Fixes indentation errors to match coding style and a typo.
-showUsage is called before mythcontext initialisation.

Changed 11 years ago by Matthew Wire <devel@…>

comment:2 Changed 11 years ago by Matthew Wire <devel@…>

00-5935-mythwelcome-showusage.patch
Updated version of previous patch:
-Adds version info to usage printout.
-showUsage is called before mythcontext initialisation.

Changed 11 years ago by Matthew Wire <devel@…>

comment:3 Changed 11 years ago by Matthew Wire <devel@…>

00-5935-mythfrontend-showusage.patch
-Changes calls from "system" to "myth_system" instead.
-Changes function name from PrintHelp? to showUsage for consistency with other myth apps.

Changed 11 years ago by Matthew Wire <devel@…>

comment:4 Changed 11 years ago by Matthew Wire <devel@…>

00-5935-mythbackend-showusage.patch
-Adds showUsage function and moves usage information into it.
-Changes calls from "system" to "myth_system" instead.

comment:5 Changed 11 years ago by danielk

Owner: changed from Isaac Richards to danielk
Status: newaccepted

Changed 11 years ago by Matthew Wire <devel@…>

Minor compile fixes due to header reorganisation

comment:6 Changed 11 years ago by danielk

Resolution: fixed
Status: acceptedclosed

(In [19504]) Fixes #5935. A few small mythshutdown fixes/reorgs from Matthew Wire.

Changed 11 years ago by Matthew Wire <devel@…>

Changed 11 years ago by Matthew Wire <devel@…>

Changed 11 years ago by Matthew Wire <devel@…>

Note: See TracTickets for help on using tickets.