Opened 11 years ago

Closed 10 years ago

#5937 closed patch (fixed)

Animated weather maps broken in trunk.

Reported by: Marc Alban <marcalban@…> Owned by: paulh
Priority: minor Milestone: 0.22
Component: mythweather Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The animated weather map screen appears to be broken in trunk.

There appear to be several issues:

1) weather-screens.xml defines Animated Map as requiring a data types "amdesc", "updatetime", and "datum". But the scripts that provide animated images all provide data types "amdesc", "updatetime", and "animatedimage". This prevents Animated Map from appearing as a possible screen to add.

2) weather-ui.xml defines an image element named "animatedimagetype" for Animated Map, but the code expects an element called "animatedimage".

3) The current code has an off by one error and tries to load one more image than exists.

4) The delay time for the image is never set so no animation occurs.

The attached patch gets the Animated Map screen working for me on trunk.

Attachments (1)

animatedmaps.diff (3.0 KB) - added by Marc Alban <marcalban@…> 11 years ago.
patch to fix animated weather maps

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by Marc Alban <marcalban@…>

Attachment: animatedmaps.diff added

patch to fix animated weather maps

comment:1 Changed 10 years ago by paulh

Milestone: unknown0.22
Owner: changed from Isaac Richards to paulh
Status: newassigned

comment:2 Changed 10 years ago by paulh

Resolution: fixed
Status: assignedclosed

(In [20527]) Fix animated maps not working in MythWeather?. Some maps still don't seem to work but most do. Patch from Marc Alban. Closes #5937.

Note: See TracTickets for help on using tickets.