Opened 11 years ago

Closed 11 years ago

#5975 closed patch (fixed)

mythconverg_restore.pl - exclude backup and restore scripts from list of backup files

Reported by: sphery <mtdean@…> Owned by: Rob Smith
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Now that the database backup and restore script filenames have been changed to start with mythconverg, they match the glob used to find backup files when a filename is not specified. In the event that a user puts the scripts in the DBBackupDirectory, one of the two scripts will be sent to the database as if it were a backup file, resulting in errors such as:

ERROR 1049 (42000) at line 11: Unknown database 'Getopt::Long'

or

ERROR 1044 (42000) at line 11: Access denied for user 'mythtv'@'localhost' to database 'Getopt::Long'

The attached patch simply adds a line that removes the script names from the list of files before sorting and finding a backup file to use.

Attachments (4)

mythtv-5975-restore-exclude_script_from_file_selection.patch (887 bytes) - added by sphery <mtdean@…> 11 years ago.
mythtv-5975-restore-exclude_script_from_file_selection-20081206.patch (1.4 KB) - added by sphery <mtdean@…> 11 years ago.
Updated patch
mythtv-5975-restore-exclude_script_from_file_selection.2.patch (1.4 KB) - added by sphery <mtdean@…> 11 years ago.
Updated patch for recent changes to trunk.
mythtv-5975_and_6013-combined.patch (2.2 KB) - added by sphery <mtdean@…> 11 years ago.
Combined version of #5975 and #6013 patches (to work around patch collisions). Can be used instead if both are applied/committed together.

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by sphery <mtdean@…>

Changed 11 years ago by sphery <mtdean@…>

Updated patch

comment:1 Changed 11 years ago by sphery <mtdean@…>

mythtv-5975-restore-exclude_script_from_file_selection-20081206.patch is an updated patch that also fixes a conditional. When rearranging verbose output, a single-line conditional was broken into two lines but only one was executed conditionally. This adds a proper conditional block.

Thanks to Jack M. for reporting the issues.

comment:2 Changed 11 years ago by Rob Smith

Owner: changed from Isaac Richards to Rob Smith
Status: newaccepted

Changed 11 years ago by sphery <mtdean@…>

Updated patch for recent changes to trunk.

Changed 11 years ago by sphery <mtdean@…>

Combined version of #5975 and #6013 patches (to work around patch collisions). Can be used instead if both are applied/committed together.

comment:3 Changed 11 years ago by Rob Smith

Resolution: fixed
Status: acceptedclosed

(In [20607]) Fixes #5975 and Fixes #6013, a few more patches by Mr. Dean for the db restore script

Note: See TracTickets for help on using tickets.