Opened 12 years ago
Closed 11 years ago
#5993 closed defect (fixed)
win32packager mythplugins make install installs dlls in the wrong location
Reported by: | Owned by: | Nigel | |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | mythtv | Version: | unknown |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
It seems that the DLLs installed by the make install command in the win32-packager script are installed in the wronf folder, the installation puts them in:
$build/bin/mythtv/plugins
but they are not picked up by mythfrontend when they are located there, where if you copy them to
$build/share/mythtv/plugins
they are picked up by mythfrontend and displayed in the menus.
Attachments (2)
Change History (9)
Changed 12 years ago by
Attachment: | 5993_plugins.patch added |
---|
Changed 12 years ago by
Attachment: | 5993_packager.patch added |
---|
Corresponding fix for win32_packager.pl
comment:1 Changed 12 years ago by
I've attached two patches to fix this problem: 5993_plugins.patch - fix plugin install dir and mythvideo naming for win32 5993_packager.patch - corresponding change to win32_packager script
comment:2 Changed 12 years ago by
The change to win32-packager.pl seems correct, but is reverting part of one of David's old patches [18464].
The targetdep.pro one will work, but is a little fragile. It would be better to use a different variable name (e.g. SHARELIBDIR for the installs, or LIBDEPS for the dependencies). I will try to do some testing.
I don't understand the need for the mythvideo.pro one?
comment:3 Changed 12 years ago by
mythvideo.pro fix is just to get the file named correctly... Currently, the mythvideo plugin is built as mythvideo.dll, which is not recognized by win32 frontend. The libs-targetfix.pro include sets the name to libmythvideo.dll
All of the other plugins already have libs-targetfix.pro included in their respective .pro files; it seems mythvideo was missed when these includes went in.
comment:4 Changed 12 years ago by
Nigel, these both look OK to me, and seems a better long-term solution than what I originally presented in [18474], so long as it worked in practice. ( I have not tried it). - David/Buzz?.
comment:5 Changed 11 years ago by
Owner: | changed from Isaac Richards to Nigel |
---|---|
Status: | new → assigned |
Fix .pro files to install plugins correctly on win32