MythMusci does not compile on windows

[Jonathan Martens <jonathan@…>]

Since my patch (in #5980) that removes usleep from compat.h some plugins fail compilation in windows, MythMusic is one of them.

It can be fixed with attached patch. Although compilations halts on another issue as well:

g++ -c -march=k8 -g -Wall -Wno-switch -Wpointer-arith -Wredundant-decls -Wno-non
-virtual-dtor -funit-at-a-time -D__STDC_CONSTANT_MACROS -g -frtti -fexceptions -
mthreads -Wall -DUNICODE -DQT_LARGEFILE_SUPPORT -DUSING_MINGW -D_GNU_SOURCE -DPR
EFIX="U:/mythtv/build/" -DMMX -Di386 -DUSING_DIRECTX -D_FILE_OFFSET_BITS=64 -DQT
_THREAD_SUPPORT -DQT_DLL -DQT_PLUGIN -DQT_QT3SUPPORT_LIB -DQT3_SUPPORT -DQT_SQL_
LIB -DQT_XML_LIB -DQT_OPENGL_LIB -DQT_GUI_LIB -DQT_CORE_LIB -I'../../../../MSys/
1.0/qt-win-opensource-src-4.4.3/include/QtCore' -I'../../../../MSys/1.0/qt-win-o
pensource-src-4.4.3/include/QtCore' -I'../../../../MSys/1.0/qt-win-opensource-sr
c-4.4.3/include/QtGui' -I'../../../../MSys/1.0/qt-win-opensource-src-4.4.3/inclu
de/QtGui' -I'../../../../MSys/1.0/qt-win-opensource-src-4.4.3/include/QtOpenGL'
-I'../../../../MSys/1.0/qt-win-opensource-src-4.4.3/include/QtOpenGL' -I'../../.
./../MSys/1.0/qt-win-opensource-src-4.4.3/include/QtXml' -I'../../../../MSys/1.0
/qt-win-opensource-src-4.4.3/include/QtXml' -I'../../../../MSys/1.0/qt-win-opens
ource-src-4.4.3/include/QtSql' -I'../../../../MSys/1.0/qt-win-opensource-src-4.4
.3/include/QtSql' -I'../../../../MSys/1.0/qt-win-opensource-src-4.4.3/include/Qt
3Support' -I'../../../../MSys/1.0/qt-win-opensource-src-4.4.3/include/Qt3Support
' -I'../../../../MSys/1.0/qt-win-opensource-src-4.4.3/include' -I'../../../build
/include' -I'../../../build/include' -I'../../../build/include/mythtv' -I'/usr/i
nclude/taglib' -I'/usr/include/cdda' -I'u:/MSys/1.0/qt-win-opensource-src-4.4.3/
include/ActiveQt' -I'.' -I'.' -I'../../../../MSys/1.0/qt-win-opensource-src-4.4.
3/mkspecs/win32-g++' -o cddecoder-windows.o cddecoder-windows.cpp
In file included from cddecoder-windows.cpp:19:
../../../build/include/mythtv/httpcomms.h:9:17: QHttp: No such file or directory

In file included from cddecoder-windows.cpp:19:
../../../build/include/mythtv/httpcomms.h:19: error: `QHttpRequestHeader' has no
t been declared
../../../build/include/mythtv/httpcomms.h:19: error: ISO C++ forbids declaration
 of `header' with no type
../../../build/include/mythtv/httpcomms.h:68: error: `QHttpRequestHeader' has no
t been declared
../../../build/include/mythtv/httpcomms.h:75: error: ISO C++ forbids declaration
 of `pAddlHdr' with no type
../../../build/include/mythtv/httpcomms.h:78: error: `QHttpRequestHeader' has no
t been declared
../../../build/include/mythtv/httpcomms.h:78: error: ISO C++ forbids declaration
 of `header' with no type
../../../build/include/mythtv/httpcomms.h:102: error: `QHttpRequestHeader' has n
ot been declared
../../../build/include/mythtv/httpcomms.h:102: error: ISO C++ forbids declaratio
n of `request' with no type
../../../build/include/mythtv/httpcomms.h:109: error: expected `,' or `...' befo
re '&' token
../../../build/include/mythtv/httpcomms.h:109: error: ISO C++ forbids declaratio
n of `QHttpResponseHeader' with no type
../../../build/include/mythtv/httpcomms.h:117: error: ISO C++ forbids declaratio
n of `QHttp' with no type
../../../build/include/mythtv/httpcomms.h:117: error: expected `;' before '*' to
ken
../../../build/include/mythtv/httpcomms.h:129: error: `QHttpRequestHeader' does
not name a type
make[1]: *** [cddecoder-windows.o] Error 1
make[1]: Leaving directory `/u/mythtv/mythplugins/mythmusic/mythmusic'
make: *** [sub-mythmusic-make_default] Error 2

[Nigel]

iconview.cpp is part of mythgallery, not mythmusic. It was patched in [21995]

[Jonathan Martens <jonathan@…>]

Replying to nigel:

iconview.cpp is part of mythgallery, not mythmusic. It was patched in [21995]

Oops I think I attached the wrong patch then, I think we can keep this closed indeed as we already have #5987 to track MythMusic.