Opened 11 years ago

Closed 10 years ago

#6032 closed enhancement (fixed)

Add Flag for HD resolutions in videoprops, display resolution in Watch Recordings

Reported by: robert.mcnamara@… Owned by: stuartm
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords: resolution icons watch recordings
Cc: Ticket locked: no

Description

This set of patches adds two new videoprops, VID_720 and VID_1080 to programinfo. It also adds two new programinfo functions, GetHeight? and SetVidpropHeight?. GetHeight? gets the program's vertical resolution from recordedmarkup. SetVidPropHeight? matches the supplied height to conditions (700-800 = 720p, 1000-1100 = 1080i/p) and turns on the flag for 720p/1080ip material. tv_rec.cpp is patched to set the flags at the end of a recording. I've patched the Watch Recordings screen in all themes to use this information. The end result is something like this:

http://www.fecitfacta.com/hdicons.png http://www.fecitfacta.com/hdicons2.png

Everything should work fine at the moment, will probably update the GetHeight? SQL query slightly in the next day or two to account for channels that might change resolution mid-stream.

Attachments (11)

HDicons.codechanges.diff (7.9 KB) - added by robert.mcnamara@… 11 years ago.
Changes to the mythtv code
HDicons.themechanges.diff (4.6 KB) - added by robert.mcnamara@… 11 years ago.
Changes to the myththemes code
HDicons.icons.tar.gz (2.4 KB) - added by robert.mcnamara@… 11 years ago.
Icons needed for these patches (place in mythtv/themes/default)
HDicons.codechanges.2.diff (8.5 KB) - added by robert.mcnamara@… 11 years ago.
Fixed SQL query should work properly if resolutions change mid-stream.
HDicons.codechanges.noPBB.diff (6.1 KB) - added by robert.mcnamara@… 11 years ago.
Code changes without touching PBB
HDicons.codechanges.noPBB.011208.diff (6.3 KB) - added by robert.mcnamara@… 11 years ago.
Updates to account for recent changes in programinfo/progdetails
HDIcons.NoPBB.022309.diff (6.4 KB) - added by robert.mcnamara@… 11 years ago.
Updated, tested, working.
getwidthtoo.diff (4.6 KB) - added by robert.mcnamara@… 11 years ago.
Adds getwidth and uses it to calculate overall resolution (allows for weirdo cropped material)
redux.diff (5.2 KB) - added by robert.mcnamara@… 11 years ago.
Makes requested changes.
redux.2.diff (5.2 KB) - added by robert.mcnamara@… 11 years ago.
*sigh*
resflagging.diff (5.1 KB) - added by robert.mcnamara@… 10 years ago.
Updated against trunk

Download all attachments as: .zip

Change History (15)

Changed 11 years ago by robert.mcnamara@…

Attachment: HDicons.codechanges.diff added

Changes to the mythtv code

Changed 11 years ago by robert.mcnamara@…

Attachment: HDicons.themechanges.diff added

Changes to the myththemes code

Changed 11 years ago by robert.mcnamara@…

Attachment: HDicons.icons.tar.gz added

Icons needed for these patches (place in mythtv/themes/default)

Changed 11 years ago by robert.mcnamara@…

Attachment: HDicons.codechanges.2.diff added

Fixed SQL query should work properly if resolutions change mid-stream.

comment:1 Changed 11 years ago by robert.mcnamara@…

SQL Query now updated to account for mid-stream resolution changes. Most number of frames at a given resolution wins. So, to recap, apply these two:

HDicons.codechanges.2.diff (to trunk/mythtv) HDicons.themechanges.diff (to trunk/myththemes)

and untar the contents of HDicons.icons.tar.gz in themes/default.

Enjoy!

comment:2 Changed 11 years ago by stuartm

Owner: changed from Isaac Richards to stuartm
Status: newaccepted

Changed 11 years ago by robert.mcnamara@…

Code changes without touching PBB

Changed 11 years ago by robert.mcnamara@…

Updates to account for recent changes in programinfo/progdetails

Changed 11 years ago by robert.mcnamara@…

Attachment: HDIcons.NoPBB.022309.diff added

Updated, tested, working.

comment:3 Changed 11 years ago by stuartm

(In [20067]) Adds two additional video properties to indicate the video resolution recordings marked as HD. Includes support for retrieving this information during recording and setting/retriving it from the database. Patch by Robert McNamara?. Refs #6032

Changed 11 years ago by robert.mcnamara@…

Attachment: getwidthtoo.diff added

Adds getwidth and uses it to calculate overall resolution (allows for weirdo cropped material)

Changed 11 years ago by robert.mcnamara@…

Attachment: redux.diff added

Makes requested changes.

Changed 11 years ago by robert.mcnamara@…

Attachment: redux.2.diff added

*sigh*

Changed 10 years ago by robert.mcnamara@…

Attachment: resflagging.diff added

Updated against trunk

comment:4 Changed 10 years ago by stuartm

Resolution: fixed
Status: acceptedclosed

(In [20799]) Balance of the resolution flag and icon support. Patch from Robert McNamara?. Closes #6032

Note: See TracTickets for help on using tickets.