Opened 12 years ago
Closed 11 years ago
#6032 closed enhancement (fixed)
Add Flag for HD resolutions in videoprops, display resolution in Watch Recordings
| Reported by: | Owned by: | stuartm | |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | mythtv | Version: | head |
| Severity: | low | Keywords: | resolution icons watch recordings |
| Cc: | Ticket locked: | no |
Description
This set of patches adds two new videoprops, VID_720 and VID_1080 to programinfo. It also adds two new programinfo functions, GetHeight? and SetVidpropHeight?. GetHeight? gets the program's vertical resolution from recordedmarkup. SetVidPropHeight? matches the supplied height to conditions (700-800 = 720p, 1000-1100 = 1080i/p) and turns on the flag for 720p/1080ip material. tv_rec.cpp is patched to set the flags at the end of a recording. I've patched the Watch Recordings screen in all themes to use this information. The end result is something like this:
http://www.fecitfacta.com/hdicons.png http://www.fecitfacta.com/hdicons2.png
Everything should work fine at the moment, will probably update the GetHeight? SQL query slightly in the next day or two to account for channels that might change resolution mid-stream.
Attachments (11)
Change History (15)
Changed 12 years ago by
| Attachment: | HDicons.codechanges.diff added |
|---|
Changed 12 years ago by
| Attachment: | HDicons.icons.tar.gz added |
|---|
Icons needed for these patches (place in mythtv/themes/default)
Changed 12 years ago by
| Attachment: | HDicons.codechanges.2.diff added |
|---|
Fixed SQL query should work properly if resolutions change mid-stream.
comment:1 Changed 12 years ago by
SQL Query now updated to account for mid-stream resolution changes. Most number of frames at a given resolution wins. So, to recap, apply these two:
HDicons.codechanges.2.diff (to trunk/mythtv) HDicons.themechanges.diff (to trunk/myththemes)
and untar the contents of HDicons.icons.tar.gz in themes/default.
Enjoy!
comment:2 Changed 12 years ago by
| Owner: | changed from Isaac Richards to stuartm |
|---|---|
| Status: | new → accepted |
Changed 12 years ago by
| Attachment: | HDicons.codechanges.noPBB.diff added |
|---|
Code changes without touching PBB
Changed 12 years ago by
| Attachment: | HDicons.codechanges.noPBB.011208.diff added |
|---|
Updates to account for recent changes in programinfo/progdetails
comment:3 Changed 12 years ago by
Changed 12 years ago by
| Attachment: | getwidthtoo.diff added |
|---|
Adds getwidth and uses it to calculate overall resolution (allows for weirdo cropped material)
Changes to the mythtv code