Opened 11 years ago

Closed 11 years ago

#6034 closed patch (fixed)

Add missing check to see if the channel icons is defined for each channel in guidegrid.cpp

Reported by: Stephen <stev391@…> Owned by: danielk
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: medium Keywords: channel icons program guide
Cc: Ticket locked: no

Description

The attached patch fixes a bug in the program guide were if you have selected to show channel icons it would request the file even if it wasn't defined for this channel in the database. The patch just adds a missing check (which is completed for other paths in the code) to ensure it doesn't query for the file. This fixes a guide slowdown for me under certain network conditions.

Attachments (2)

fix.channel.icons.patch (535 bytes) - added by Stephen <stev391@…> 11 years ago.
Adds an additional sanity check.
fix.channel.icons.0.1.patch (557 bytes) - added by Stephen <stev391@…> 11 years ago.
Adds an additional sanity check.

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by Stephen <stev391@…>

Attachment: fix.channel.icons.patch added

Adds an additional sanity check.

Changed 11 years ago by Stephen <stev391@…>

Attachment: fix.channel.icons.0.1.patch added

Adds an additional sanity check.

comment:1 Changed 11 years ago by Stephen <stev391@…>

Please disregard the patch: "fix.channel.icons.patch" This caused a regression in that the icon for the information display area was not cleared correctly.

Patch: "fix.channel.icons.0.1.patch" fixes the reported issue without this regression.

comment:2 Changed 11 years ago by danielk

Owner: changed from Isaac Richards to danielk
Status: newaccepted

comment:3 Changed 11 years ago by danielk

Resolution: fixed
Status: acceptedclosed

(In [19559]) Fixes #6034. Don't try to load a channel icon if the file name is empty.

Note: See TracTickets for help on using tickets.