Opened 14 years ago

Closed 14 years ago

#608 closed patch (fixed)

Separate OSD display and repositioning

Reported by: mythtv@… Owned by: danielk
Priority: minor Milestone: 0.19
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I've noticed two issues regarding sound and the OSD:

  • If I press "Play" while at normal speed just to get the OSD on (to see where I am in the recording), the sound is muted for a short time
  • If I press "Fast forward", the sound is muted, then brief one, then off again.

This patch replaces "UpdatePosOSD" with two functions "UpdateOSD" and "UpdatePos?". UpdateOSD displays the OSD (requiring no mute). UpdatePos? does a skip, where a mute might be helpful in avoiding start-up glitches in the sound.

For "Play" and "Fast forward", there is no call to UpdatePos?, so no mute. For fast forward, the sound card plays the audio in its buffer and then stops cleanly (in my tests). As to my pressing "Play" to get the OSD, there is no audio muting at all (which, of the two, is the much nicer change).

Attachments (1)

briefsound.patch (5.7 KB) - added by mythtv@… 14 years ago.
Proposed patch

Download all attachments as: .zip

Change History (3)

Changed 14 years ago by mythtv@…

Attachment: briefsound.patch added

Proposed patch

comment:1 Changed 14 years ago by danielk

Milestone: 0.19
Owner: changed from Isaac Richards to danielk
Version: head

comment:2 Changed 14 years ago by danielk

Resolution: fixed
Status: newclosed

(In [7832]) Closes #608, by applying patch + small tweaks.

This prevents muting the audio when you are not actually performing a seek. It does this by decoupling the update and display of the position OSD from seeking, and only updating the OSD without a null seek when no seeking is required.

Note: See TracTickets for help on using tickets.