Opened 11 years ago

Closed 10 years ago

#6105 closed patch (fixed)

mythlcdserver uses deprecated interface to lcdproc

Reported by: avdongen@… Owned by: paulh
Priority: minor Milestone: 0.22
Component: MythTV - Mythlcdserver Version: head
Severity: low Keywords: lcdproc priorities
Cc: Ticket locked: no

Description

Hi all,

I found that the mythlcdserver module does not correctly set the display priorities for lcdproc version 0.5 and higher. This leads to incorrect display contents.

LCDProc versions up to 0.4 used numeric priority values, and 0.5 and higher use text strings for priorities. There is limited backwards compatibility, but this is not complete and Myth does not use the correct numbers.

I created a patch to fix this. The patch is based on SVN-0.21-20080706, but I think there were not many other changes in these files so it can be applied to trunk without much hassle.

Attachments (1)

priopatch (3.0 KB) - added by avdongen@… 11 years ago.
Patch to send priority names instead of numbers to lcdproc

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by avdongen@…

Attachment: priopatch added

Patch to send priority names instead of numbers to lcdproc

comment:1 Changed 11 years ago by Dibblah

Status: newinfoneeded_new

Thanks for the patch!

A couple of comments: There are a few whitespace / bracket changes that are cosmetic and don't seem correct to me. Has this actually been tested with 0.4?

comment:2 in reply to:  1 Changed 11 years ago by avdongen@…

Replying to Dibblah:

Thanks for the patch!

You're welcome!

A couple of comments: There are a few whitespace / bracket changes that are cosmetic and don't seem correct to me.

The compiler was complaining about the ambiguous nested ifs and suggested brackets, so I added them. It should not make any difference in the binary output. And if my other patch is accepted, this small section is removed anyway.

Has this actually been tested with 0.4?

No I haven't tested it against 0.4, my LCD is not supported before 0.5. But I fooled mythlcdserver to use the 0.4 interface on 0.5 anyway. Using verbose debugging it showed the same messages with and without the patch, so I considered it safe.

comment:3 Changed 10 years ago by danielk

Status: infoneeded_newnew

comment:4 Changed 10 years ago by paulh

Component: mythtvMythTV - Mythlcdserver
Milestone: unknown0.22
Owner: changed from Isaac Richards to paulh
Status: newassigned
Version: 0.21head

comment:5 Changed 10 years ago by paulh

Resolution: fixed
Status: assignedclosed

(In [20559]) Use the standard screen priorities provided by lcdproc 0.5 rather than the non standard numeric ones we've always used. If you just use the LCD for Myth it wont make any difference but if you use other lcdproc clients then Myths screens will now rotate along with other clients screens of similar priority. Fixes #6105.

Note: See TracTickets for help on using tickets.