Opened 11 years ago

Closed 11 years ago

#6145 closed defect (fixed)

blootubelite-wide menu-ui.xml file corruption

Reported by: jrigg@… Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: theme Version: unknown
Severity: low Keywords:
Cc: Ticket locked: no

Description

theme blootubelite-wide has file "menu-ui.xml" that is corrupted begin at line 710. A fixed version needs to be checked in.

A temporary fix is to copy menu-ui.xml from blootube-wide theme directory.

Change History (3)

comment:1 Changed 11 years ago by robert.mcnamara@…

Index: blootubelite-wide/menu-ui.xml
===================================================================
--- blootubelite-wide/menu-ui.xml	(revision 19740)
+++ blootubelite-wide/menu-ui.xml	(working copy)
@@ -707,10 +707,10 @@
         </state>
 
         <state name="TV_SETTINGS_PLAYBACK_GROUPS">
-            <image>ui/button_off.png</filename></imagetype></state>
-    <filename>watermark/pgroups.png</filename>
-</imagetype>
-</state>
+            <imagetype name="watermark">
+                <filename>watermark/pgroups.png</filename>
+            </imagetype>
+        </state>
 
 <state name="TV_SETTINGS_PLAYBACK_OSD">
     <imagetype name="watermark">

Doesn't it sort of go without saying that any bug needs a fix to be checked in? Hmmm.

comment:2 in reply to:  1 Changed 11 years ago by anonymous

Replying to robert.mcnamara@gmail.com:

Doesn't it sort of go without saying that any bug needs a fix to be checked in? Hmmm.

I was being kind by implying that the maintainer had a correct copy of the file and the corruption occurred in the repository. All that he needed to do was recheck in the good copy.

Your right though, I should have assumed that the maintainer failed to perform any rudimentary test prior to checking it in. Kind of like checking in "C" code that doesn't compile.

There is more wrong with this file than your suggested fix (I guess you would know that if you had bothered to try you fix before posting it) and I don't know what the designer/maintainer had in mind for the layout, etc. I can make the file work by adding window and font definitions plus other fixes, but I think the maintainer should either checkin his good working copy, or generate a good/working copy and check it in.

comment:3 Changed 11 years ago by Justin Hornsby

Resolution: fixed
Status: newclosed

(In [19743]) Closes #6145. Copied menu-ui.xml from blootube-wide and adjusted the watermarks location to 200,200.

Note: See TracTickets for help on using tickets.