Opened 15 years ago
Closed 15 years ago
Last modified 15 years ago
#6238 closed patch (fixed)
Don't warn about menu <action> handled by callbacks
Reported by: | Owned by: | paulh | |
---|---|---|---|
Priority: | minor | Milestone: | 0.22 |
Component: | MythTV - General | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
In [19940], one of Nigel's changes included a, "Warning for garbage in menu action." However, it seems to be a little too eager to warn, as it warns about <action>s handled by callbacks.
For example, the <action> for the <button> "Watch Recordings" (in tvmenu.xml of defaultmenu) is "TV_WATCH_RECORDING", which isn't handled in MythThemedMenu::handleAction(), but is handled by TVMenuCallback() in programs/mythfrontend/main.cpp. This means that we get the warning:
2009-02-07 14:07:38.624 Unknown menu action: TV_WATCH_RECORDING
But then we handle TV_WATCH_RECORDING, properly due to the callback code immediately following the warning. The attached patch seems to fix the issue by only warning when there is no callback or when the action isn't handled by a callback, as I would think an action handled by a callback is not garbage.
Thanks to Stuart M. for explaining to me how this is supposed to work.
Attachments (1)
Change History (4)
Changed 15 years ago by
Attachment: | mythtv-no_warning_for_menu_actions_handled_by_callbacks.patch added |
---|
comment:1 Changed 15 years ago by
Milestone: | unknown → 0.22 |
---|---|
Owner: | changed from Isaac Richards to paulh |
Status: | new → assigned |
comment:2 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
(In [19996]) Fix the unknown menu action warnings. Patch by sphery. Fixes #6238.