Opened 15 years ago
Closed 15 years ago
#6264 closed defect (fixed)
Handle multiple movies in tmdb.pl, handle zero cast
Reported by: | paul [at] planar.id.au | Owned by: | Anduin Withers |
---|---|---|---|
Priority: | minor | Milestone: | 0.22 |
Component: | Plugin - MythVideo | Version: | head |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
The tmdb.pl script has a couple of defects.
If there are multiple movies that match a imdb id, it fails to return posters or movie data. This fix forces movie to always be treated as an array, for posters it looks in all movies present to find a poster, for movie info it wasn't as straight forward, so I always looked at the first movie listed. A few test cases suggests tmdb puts the results with more data at the top anyway.
Also fixed a defect where a movie with no cast would return an error.
Test cases:
- movie with two results - Emma:
/usr/share/mythtv/server/mythvideo/scripts/tmdb.pl -D 0116191
- movie with no cast - Eagles Hell Freezes Over
/usr/share/mythtv/server/mythvideo/scripts/tmdb.pl -D 0123815
Attachments (2)
Change History (6)
Changed 15 years ago by
Attachment: | tmdb.pl.diff added |
---|
comment:1 Changed 15 years ago by
Milestone: | unknown → 0.22 |
---|---|
Status: | new → assigned |
Version: | unknown → head |
Could you request the removal of the duplicates in the TMDB forum please.
comment:2 Changed 15 years ago by
I have submitted a request to tmdb to clean up duplicates. Unfortunately I think even if some process is introduced to clean them up, there will still be periods of time where a duplicate exists. The current behaviour of the tmdb.pl script is less than desirable in that situation - as an end user you basically get no response at all. So I think the change to the script is still worthwhile - at least that way you get something back.
comment:3 Changed 15 years ago by
Status: | assigned → infoneeded |
---|
Please provide an updated patch, if you don't create it with 'svn diff' at least be reasonable.
diff file for tmdb.pl