Opened 11 years ago

Closed 11 years ago

#6264 closed defect (fixed)

Handle multiple movies in tmdb.pl, handle zero cast

Reported by: paul [at] planar.id.au Owned by: Anduin Withers
Priority: minor Milestone: 0.22
Component: Plugin - MythVideo Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

The tmdb.pl script has a couple of defects.

If there are multiple movies that match a imdb id, it fails to return posters or movie data. This fix forces movie to always be treated as an array, for posters it looks in all movies present to find a poster, for movie info it wasn't as straight forward, so I always looked at the first movie listed. A few test cases suggests tmdb puts the results with more data at the top anyway.

Also fixed a defect where a movie with no cast would return an error.

Test cases:

  • movie with two results - Emma:

/usr/share/mythtv/server/mythvideo/scripts/tmdb.pl -D 0116191

  • movie with no cast - Eagles Hell Freezes Over

/usr/share/mythtv/server/mythvideo/scripts/tmdb.pl -D 0123815

Attachments (2)

tmdb.pl.diff (2.9 KB) - added by paul [at] planar.id.au 11 years ago.
diff file for tmdb.pl
tmdb.pl.2.diff (2.9 KB) - added by paul [at] planar.id.au 11 years ago.
Left a dump statement in the code - fixed

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by paul [at] planar.id.au

Attachment: tmdb.pl.diff added

diff file for tmdb.pl

Changed 11 years ago by paul [at] planar.id.au

Attachment: tmdb.pl.2.diff added

Left a dump statement in the code - fixed

comment:1 Changed 11 years ago by stuartm

Milestone: unknown0.22
Status: newassigned
Version: unknownhead

Could you request the removal of the duplicates in the TMDB forum please.

comment:2 Changed 11 years ago by paul [at] planar.id.au

I have submitted a request to tmdb to clean up duplicates. Unfortunately I think even if some process is introduced to clean them up, there will still be periods of time where a duplicate exists. The current behaviour of the tmdb.pl script is less than desirable in that situation - as an end user you basically get no response at all. So I think the change to the script is still worthwhile - at least that way you get something back.

comment:3 Changed 11 years ago by Anduin Withers

Status: assignedinfoneeded

Please provide an updated patch, if you don't create it with 'svn diff' at least be reasonable.

comment:4 Changed 11 years ago by Anduin Withers

Resolution: fixed
Status: infoneededclosed

Closes #6264

Fixes issues with TMDB I know about and can reproduce, guess fix multiple results bug.

Made it look better, to me.

Note: See TracTickets for help on using tickets.