Opened 11 years ago

Closed 11 years ago

#6289 closed defect (fixed)

MythWeb recorded programs RSS and non-ascii characters in titles

Reported by: otto at kolsi dot fi Owned by: Rob Smith
Priority: minor Milestone: unknown
Component: Plugin - MythWeb Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

MythWeb Recorded Programs RSS feed breaks if program titles contain non-ascii characters. For example, title "Tv-uutiset ja sää" becomes:

<title>Tv-uutiset ja s&Atilde;&curren;&Atilde;&curren;</title>

Adding utf8_decode() call to tv/tmpl/rss/recorded.php where title is set, makes it better:

<title>Tv-uutiset ja s&auml;&auml;</title>

but it is still broken because of the entities (http://validator.w3.org/feed/). Is it possible to output this RSS-feed through MythWeb without doing the entity encoding for this file?

Attachments (1)

mythweb-feed-non-ascii.patch (1.0 KB) - added by otto at kolsi dot fi 11 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 11 years ago by Rob Smith

Owner: changed from xris to Rob Smith
Status: newaccepted

comment:2 Changed 11 years ago by Rob Smith

Resolution: fixed
Status: acceptedclosed

(In [20244]) Hopefully fixes #6289, converts utf-8 to iso8859-1 and urldecodes them.

Changed 11 years ago by otto at kolsi dot fi

comment:3 Changed 11 years ago by otto at kolsi dot fi

[20244] did not fix this, ticket should be re-opened (don't have permissions to do so).

Root of the problem seems to be the fact that FeedWriter?.php does HTML entity encoding for the RSS data. RSS data is in fact XML and thus most of the HTML entities do not work but break the XML (since without additional declarations, XML can contain only 5 entities).

Attached patch removes HTML-entity encoding and also removes previous UTF-8/URL -decode calls (which now need to be removed when entities are not used). With this applied, non-ascii characters work both in program titles and descriptions.

comment:4 Changed 11 years ago by Rob Smith

Resolution: fixed
Status: closednew

comment:5 Changed 11 years ago by Rob Smith

Resolution: fixed
Status: newclosed

(In [20392]) Fixes #6289, allows non-ascii rss feeds to work correctly

Note: See TracTickets for help on using tickets.