Opened 12 years ago

Closed 12 years ago

#6307 closed patch (fixed)

Custom Records loose hard post-roll after an episodes is watched and deleted

Reported by: jppoet@… Owned by: danielk
Priority: minor Milestone: 0.22
Component: MythTV - Scheduling Version: head
Severity: medium Keywords: Custom Record
Cc: Ticket locked: no

Description

Create a Custom Record schedule with a hard post-roll. Watch even a little bit of an episode recording using that rule and then delete it. Result is the hard-post roll getting lost from the recording rule.

An episode must be watched at least a little bit. Deleting an episode that has never been watched does not seem to trigger the problem.

After the episode is watched, deleting it from playback or from the PBB is sufficient to trigger the problem.

Episode has to still be in the process of recording to trigger the problem.

Attachments (1)

TV_dtor_noStopStuff.diff (447 bytes) - added by Shane Shrybman 12 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 years ago by Shane Shrybman

Milestone: unknown0.22
Type: defectpatch
Version: unknownhead

Heh, I was wondering where that 10 min endoffset kept going. :)

I think the bug can stomp on the endoffset whenever an in progress recording is viewed.

The TV dtor ends up calling TVRec::StopLiveTV() when it shouldn't and that calls TVRec::NotifySchedulerOfRecording?() which does a bunch of things including setting the endoffset to 0 and saving it.

I'm guessing the call to TV::StopStuff?(..) in the TV dtor is redundant and can just be removed. That's what the attached patch does and it seems to do the job. TV::StopStuff?() is now only called once as well.

Changed 12 years ago by Shane Shrybman

Attachment: TV_dtor_noStopStuff.diff added

comment:2 Changed 12 years ago by jppoet@…

Thanks gnome42!

In a contrived test, the TV_dtor_noStopStuff.diff fixes the problem. I will find out this weekend if it fixes it in practice.

comment:3 Changed 12 years ago by jppoet@…

gnome42's patch fixes the problem nicely.

comment:4 in reply to:  3 Changed 12 years ago by gigem

Owner: changed from bjm to danielk
Status: newassigned

Replying to jppoet@gmail.com:

gnome42's patch fixes the problem nicely.

I think gnome42's change is reasonable and probably correct. The offending code was Daniel's, though, so I'd like home to check it first before committing it. I vaguely remember Daniel saying he would be gone for a week or two, or maybe he's just really busy. Either way, let's give him a few more days.

comment:5 Changed 12 years ago by shane

Resolution: fixed
Status: assignedclosed

(In [20230]) Closes #6307 Redundant call to TV::StopStuff?(..) causes problems when viewing an in progress recording.

Note: See TracTickets for help on using tickets.