Opened 15 years ago
Closed 15 years ago
Last modified 14 years ago
#6314 closed defect (fixed)
PID filtering of data streams is broken
Reported by: | stuartm | Owned by: | Janne Grunau |
---|---|---|---|
Priority: | trivial | Milestone: | 0.22 |
Component: | MythTV - DVB/ATSC | Version: | head |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | yes |
Description
Configured to record TV only, however since around the time of the initial QT4 port the filters have failed to remove data streams including MHEG etc
Known issue, but I'm opening the ticket to make sure it doesn't fall between the cracks before the release of 0.22.
Attachments (2)
Change History (10)
comment:1 Changed 15 years ago by
Changed 15 years ago by
Attachment: | data_pid_filtering.diff added |
---|
comment:2 Changed 15 years ago by
Patch doesn't seem to break anything, but it doesn't stop data streams from being recorded on 'TV Only' profiles either.
comment:3 Changed 15 years ago by
Milestone: | 0.22 → unknown |
---|---|
Priority: | critical → trivial |
Severity: | medium → low |
Not really critical bfr 0.22, all that happens is extra streams are recorded.
Changed 15 years ago by
Attachment: | mbe_pid_filter_patch.log.gz added |
---|
mythbackend log with patch showing VBI (private-data) and TVGx (private-sec) streams getting filtered
comment:4 Changed 15 years ago by
Milestone: | unknown → 0.22 |
---|---|
Owner: | changed from danielk to Janne Grunau |
Status: | new → accepted |
comment:5 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
(In [21575]) set the proper recording type in *StreamData? when a recording starts. Fixes #5192, Fixes #6314
comment:6 Changed 14 years ago by
(In [23788]) make sure recording type is set correctly in MPEGStreamData
DTVSignalMonitor::SetProgramNumber?|SetDVBService|SetChannel? might reset the streamdata and set the recording type to "all". Call SetRecordingType?() after them to be sure the setting sticks. Refs #6314 since the ticket was probably only fixed for the first tuning request.
comment:7 Changed 14 years ago by
(In [23814]) backports [23788] from trunk
make sure recording type is set correctly in MPEGStreamData
DTVSignalMonitor::SetProgramNumber?|SetDVBService|SetChannel? might reset the streamdata and set the recording type to "all". Call SetRecordingType?() after them to be sure the setting sticks. Refs #6314 since the ticket was probably only fixed for the first tuning request.
comment:9 Changed 14 years ago by
Ticket locked: | set |
---|
Hi gbee & Daniel,
The MPEGStreamData::_recording_type is being set correctly but then it is reset back to its default value of "all" by MPEGStreamData::Reset() called via other methods such as sm->SetDVBService(netid, tsid, progNum).
One option for fixing this is to reorder things and always ensure that the recording_type is set after Reset() is called. However, a better option is to not reset the _recording_type to "all" in Reset(). recording_type is a property of the recording profile and does not need to be reset at every stream data reset.
It looks like the "Audio Only" option also suffers from the same problem will record from the data pids.
Attached is a proposed patch to fix both issues. Untested :)