Opened 11 years ago

Closed 10 years ago

Last modified 9 years ago

#6314 closed defect (fixed)

PID filtering of data streams is broken

Reported by: stuartm Owned by: Janne Grunau
Priority: trivial Milestone: 0.22
Component: MythTV - DVB/ATSC Version: head
Severity: low Keywords:
Cc: Ticket locked: yes

Description

Configured to record TV only, however since around the time of the initial QT4 port the filters have failed to remove data streams including MHEG etc

Known issue, but I'm opening the ticket to make sure it doesn't fall between the cracks before the release of 0.22.

Attachments (2)

data_pid_filtering.diff (851 bytes) - added by Shane Shrybman 11 years ago.
mbe_pid_filter_patch.log.gz (14.2 KB) - added by tralph11@… 10 years ago.
mythbackend log with patch showing VBI (private-data) and TVGx (private-sec) streams getting filtered

Download all attachments as: .zip

Change History (10)

comment:1 Changed 11 years ago by Shane Shrybman

Hi gbee & Daniel,

The MPEGStreamData::_recording_type is being set correctly but then it is reset back to its default value of "all" by MPEGStreamData::Reset() called via other methods such as sm->SetDVBService(netid, tsid, progNum).

One option for fixing this is to reorder things and always ensure that the recording_type is set after Reset() is called. However, a better option is to not reset the _recording_type to "all" in Reset(). recording_type is a property of the recording profile and does not need to be reset at every stream data reset.

It looks like the "Audio Only" option also suffers from the same problem will record from the data pids.

Attached is a proposed patch to fix both issues. Untested :)

Changed 11 years ago by Shane Shrybman

Attachment: data_pid_filtering.diff added

comment:2 Changed 11 years ago by stuartm

Patch doesn't seem to break anything, but it doesn't stop data streams from being recorded on 'TV Only' profiles either.

comment:3 Changed 11 years ago by danielk

Milestone: 0.22unknown
Priority: criticaltrivial
Severity: mediumlow

Not really critical bfr 0.22, all that happens is extra streams are recorded.

Changed 10 years ago by tralph11@…

Attachment: mbe_pid_filter_patch.log.gz added

mythbackend log with patch showing VBI (private-data) and TVGx (private-sec) streams getting filtered

comment:4 Changed 10 years ago by Janne Grunau

Milestone: unknown0.22
Owner: changed from danielk to Janne Grunau
Status: newaccepted

comment:5 Changed 10 years ago by Janne Grunau

Resolution: fixed
Status: acceptedclosed

(In [21575]) set the proper recording type in *StreamData? when a recording starts. Fixes #5192, Fixes #6314

comment:6 Changed 10 years ago by Janne Grunau

(In [23788]) make sure recording type is set correctly in MPEGStreamData

DTVSignalMonitor::SetProgramNumber?|SetDVBService|SetChannel? might reset the streamdata and set the recording type to "all". Call SetRecordingType?() after them to be sure the setting sticks. Refs #6314 since the ticket was probably only fixed for the first tuning request.

comment:7 Changed 10 years ago by Janne Grunau

(In [23814]) backports [23788] from trunk

make sure recording type is set correctly in MPEGStreamData

DTVSignalMonitor::SetProgramNumber?|SetDVBService|SetChannel? might reset the streamdata and set the recording type to "all". Call SetRecordingType?() after them to be sure the setting sticks. Refs #6314 since the ticket was probably only fixed for the first tuning request.

comment:9 Changed 9 years ago by stuartm

Ticket locked: set
Note: See TracTickets for help on using tickets.