Opened 11 years ago

Closed 10 years ago

#6318 closed enhancement (fixed)

recGroup direct access for PBB

Reported by: jppoet@… Owned by: danielk
Priority: minor Milestone: 0.23
Component: MythTV - User Interface Library Version: head
Severity: medium Keywords: mythui recording groups
Cc: Ticket locked: no

Description

The recGroup-cycle.patch adds the ability to cycle through the user defined recording groups directly using the PAGERIGHT and PAGELEFT keys while in the PBB. This is much faster than bringing up the menu, and selecting which recording group to view.

The recGroup-ui.patch lets the theme optionally display the list of recording groups, with the current group highlighted.

The recGroup-Terra.patch, recGroup-default-wide.patch and recGroup-metallurgy_svn_10_01_09.patch(es) are not really polished. I am including them to demonstrate what a theme needs to do, to take advantage of the recGroup-ui feature. I also figured it would make it easier to review these patches.

I have almost 1300 recordings. Using these patches makes it much quicker to find the show I want to watch, by significantly reducing the amount of data I have to page through.

Attachments (24)

recGroup-cycle.patch (3.2 KB) - added by jppoet@… 11 years ago.
recGroup-ui.patch (3.3 KB) - added by jppoet@… 11 years ago.
recGroup-default-wide.patch (1.8 KB) - added by jppoet@… 11 years ago.
recGroup-Terra.patch (2.9 KB) - added by jppoet@… 11 years ago.
recGroup-metallurgy_svn_10_01_09.patch (1.8 KB) - added by jppoet@… 11 years ago.
recGroup-cycle-1a.patch (2.8 KB) - added by jppoet@… 11 years ago.
Remove some useless code
recGroup-cycle-v1.1.patch (2.9 KB) - added by jppoet@… 11 years ago.
new version with recGroupType getting set properly
recGroup-Terra.2.patch (2.9 KB) - added by jppoet@… 10 years ago.
Updated patch for the Terra theme
recGroup-default-wide.2.patch (1.8 KB) - added by jppoet@… 10 years ago.
Updated patch for the default-wide theme
recGroup-metallurgy_svn_10_01_09.2.patch (1.8 KB) - added by jppoet@… 10 years ago.
Update patch for the metallurgy theme
recGroup-Terra.3.patch (2.6 KB) - added by jppoet@… 10 years ago.
Update Terra patch for trunk 21437
recGroup-ui-v2.patch (3.6 KB) - added by jppoet@… 10 years ago.
Minor optimizations
recGroup-default-wide-v2.patch (1.8 KB) - added by jppoet@… 10 years ago.
Minor optimizations
recGroup-metallurgy_svn_10_01_09-v2.patch (1.8 KB) - added by jppoet@… 10 years ago.
Minor optimizations
recGroup-Terra-v4.patch (2.6 KB) - added by jppoet@… 10 years ago.
Minor optimizations
recGroup-ui-v2a.patch (3.0 KB) - added by jppoet@… 10 years ago.
Cleaned up
recGroup-ui-v2.1.patch (4.1 KB) - added by jppoet@… 10 years ago.
Update for r22552
recGroup-default-v1.patch (2.9 KB) - added by John Patrick Poet <jppoet@…> 10 years ago.
Takes advantage of #7461 & #7462 to render the recording groups
recGroup-default-wide-v3.patch (2.9 KB) - added by John Patrick Poet <jppoet@…> 10 years ago.
Takes advantage of #7461 & #7462 to render the recording groups
recGroup-Terra-v5.patch (2.5 KB) - added by John Patrick Poet <jppoet@…> 10 years ago.
Takes advantage of #7461 & #7462 to render the recording groups
recGroup-Graphite-v1.patch (2.9 KB) - added by John Patrick Poet <jppoet@…> 10 years ago.
Takes advantage of #7461 & #7462 to render the recording groups
recGroup-metallurgy-v2.patch (2.9 KB) - added by John Patrick Poet <jppoet@…> 10 years ago.
Takes advantage of #7461 & #7462 to render the recording groups
recGroup-ui-v3.patch (3.0 KB) - added by John Patrick Poet <jppoet@…> 10 years ago.
Don't display recGroup buttonlist if there is only one recording group.
recGroup-ui-v4.patch (3.0 KB) - added by jppoet@… 10 years ago.
Compatibility with r23048

Download all attachments as: .zip

Change History (41)

Changed 11 years ago by jppoet@…

Attachment: recGroup-cycle.patch added

Changed 11 years ago by jppoet@…

Attachment: recGroup-ui.patch added

Changed 11 years ago by jppoet@…

Attachment: recGroup-default-wide.patch added

Changed 11 years ago by jppoet@…

Attachment: recGroup-Terra.patch added

Changed 11 years ago by jppoet@…

Changed 11 years ago by jppoet@…

Attachment: recGroup-cycle-1a.patch added

Remove some useless code

comment:1 Changed 11 years ago by jppoet@…

Replaced the recGroup-cycle patch, with one that removes some useless code.

Changed 11 years ago by jppoet@…

Attachment: recGroup-cycle-v1.1.patch added

new version with recGroupType getting set properly

comment:2 Changed 11 years ago by jppoet@…

Attached a new version of recGroup-cycle. Just adds one line, to get recGroupType set properly.

comment:3 Changed 11 years ago by stuartm

Milestone: unknown0.23
Type: patchenhancement
Version: unknownhead

Changed 10 years ago by jppoet@…

Attachment: recGroup-Terra.2.patch added

Updated patch for the Terra theme

Changed 10 years ago by jppoet@…

Updated patch for the default-wide theme

Changed 10 years ago by jppoet@…

Update patch for the metallurgy theme

comment:4 Changed 10 years ago by jppoet@…

Added updated patches for the themes.

comment:5 Changed 10 years ago by doug@…

I realize I'm just one user, but I wanted to throw my two cents behind this patch (recGroup-cycle-v1.1.patch). I have the same problem as jppoet (lots of recordings in different groups) and this patch makes my myth experience significantly better.

Thanks jppoet! -Doug

comment:6 Changed 10 years ago by cpinkham

(In [21261]) Allow the PAGELEFT and PAGERIGHT keybindings to cycle through Recording Groups in the Watch Recordings screen.

References #6318. I'll let Stuart look the UI/theme patch attached to the ticket since he took this ticket a few months ago.

This patch is by John P Poet, but I added the locking around the Recording Group cache so that we don't try to access the cache while it is being rebuilt by PlaybackBox::FillList?().

Changed 10 years ago by jppoet@…

Attachment: recGroup-Terra.3.patch added

Update Terra patch for trunk 21437

comment:7 Changed 10 years ago by jppoet@…

Added a new recGroup-Terra.3.patch for trunk 21437

comment:8 Changed 10 years ago by stuartm

Status: newaccepted

Changed 10 years ago by jppoet@…

Attachment: recGroup-ui-v2.patch added

Minor optimizations

Changed 10 years ago by jppoet@…

Minor optimizations

Changed 10 years ago by jppoet@…

Minor optimizations

Changed 10 years ago by jppoet@…

Attachment: recGroup-Terra-v4.patch added

Minor optimizations

comment:9 Changed 10 years ago by jppoet@…

New UI patches as a result of suggestions by Stuart Morgan.

Changed 10 years ago by jppoet@…

Attachment: recGroup-ui-v2a.patch added

Cleaned up

comment:10 Changed 10 years ago by jppoet@…

Oops. recGroup-ui-v2.patch had one-line of residue from a different patch. Attaching recGroup-ui-v2a.patch, which has that residue removed.

Changed 10 years ago by jppoet@…

Attachment: recGroup-ui-v2.1.patch added

Update for r22552

comment:11 Changed 10 years ago by jppoet@…

new recGroup-ui-v2.1.patch updated for r22552.

Changed 10 years ago by John Patrick Poet <jppoet@…>

Attachment: recGroup-default-v1.patch added

Takes advantage of #7461 & #7462 to render the recording groups

Changed 10 years ago by John Patrick Poet <jppoet@…>

Takes advantage of #7461 & #7462 to render the recording groups

Changed 10 years ago by John Patrick Poet <jppoet@…>

Attachment: recGroup-Terra-v5.patch added

Takes advantage of #7461 & #7462 to render the recording groups

Changed 10 years ago by John Patrick Poet <jppoet@…>

Attachment: recGroup-Graphite-v1.patch added

Takes advantage of #7461 & #7462 to render the recording groups

Changed 10 years ago by John Patrick Poet <jppoet@…>

Takes advantage of #7461 & #7462 to render the recording groups

comment:12 Changed 10 years ago by John Patrick Poet <jppoet@…>

Added:

recGroup-default-v1.patch
recGroup-default-wide-v3.patch
recGroup-Terra-v5.patch
recGroup-Graphite-v1.patch
recGroup-metallurgy-v2.patch

All of these now take advantage of #7461 & #7462 and look much better than the previous theme patches.

Changed 10 years ago by John Patrick Poet <jppoet@…>

Attachment: recGroup-ui-v3.patch added

Don't display recGroup buttonlist if there is only one recording group.

comment:13 Changed 10 years ago by John Patrick Poet <jppoet@…>

New version of patch (v3) which will not draw the recGroup buttonlist if there is only one item in it.

comment:14 Changed 10 years ago by managementboy@…

patch does not apply anymore with trunk 23063.

patching file programs/mythfrontend/playbackbox.cpp
Hunk #1 succeeded at 474 (offset 38 lines).
Hunk #2 succeeded at 492 (offset 39 lines).
Hunk #3 FAILED at 942.
Hunk #4 succeeded at 1273 (offset 68 lines).
Hunk #5 FAILED at 1737.
2 out of 5 hunks FAILED -- saving rejects to file programs/mythfrontend/playbackbox.cpp.rej
patching file programs/mythfrontend/playbackbox.h
Hunk #1 FAILED at 314.
Hunk #2 FAILED at 328.
2 out of 2 hunks FAILED -- saving rejects to file programs/mythfrontend/playbackbox.h.rej

Changed 10 years ago by jppoet@…

Attachment: recGroup-ui-v4.patch added

Compatibility with r23048

comment:15 Changed 10 years ago by jppoet@…

Patch v4 added with compatibility for r23048.

comment:16 Changed 10 years ago by danielk

Owner: changed from stuartm to danielk
Status: acceptedassigned

comment:17 Changed 10 years ago by danielk

Resolution: fixed
Status: assignedclosed

(In [23326]) Fixes #6318. Allow the themer to show what recording group you are currently in, with inital implementations in a few of the themes.

Note: See TracTickets for help on using tickets.