Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#6465 closed defect (fixed)

Patch to remove invalid "NotListed" tags

Reported by: cizek@… Owned by: gigem
Priority: minor Milestone: unknown
Component: MythTV - General Version: 0.21-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

If I go into the Program Guide and select multiple programs to record (Single Record), often a few will be tagged "NotListed?". To get the recording to start, I have to go to the "Previously Recorded" screen, highlight the "N" flagged recordings, and select "Remove This Episode From The List". This fixes the problem and starts the recording.

I don't know why this happens -- I think it's a race condition between when the recordings are selected on the frontend, and when the scheduler performs the actual scheduling on the backend. The easiest way to duplicate it is to go into the Program Guide and quickly hit "R" on a bunch of programs.

The attached patch adds logic in Scheduler::UpdateMatches?(recordid) to remove the invalid record for the specified recordid. This fixes the problem for me.

This patch is against 0.21-fixes, but I've had same problem with trunk.

-Bill

Attachments (1)

149-clearNotListed.patch (926 bytes) - added by anonymous 11 years ago.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by anonymous

Attachment: 149-clearNotListed.patch added

comment:1 in reply to:  description Changed 11 years ago by gigem

Owner: changed from Isaac Richards to gigem
Status: newassigned

Replying to cizek@rcn.com:

I don't know why this happens -- I think it's a race condition between when the recordings are selected on the frontend, and when the scheduler performs the actual scheduling on the backend.

Yes, it's a race condition. It can occur when a new recording rule is added while the scheduler is already running. Coincidentally, I was going to test my own fix for this very problem this afternoon. I wound up going to help a friend with some other stuff instead, though, so it will be tomorrow before I commit anything. FWIW, my intended fix is similar to yours in that it ignores old rsNotListed status, but does it slightly differently.

comment:2 Changed 11 years ago by gigem

Resolution: fixed
Status: assignedclosed

(In [20408]) Work around a race condition in the scheduler that can cause programs to be incorrectly marked as rsNotListed. Fixes #6465

comment:3 Changed 11 years ago by gigem

(In [20409]) Backport of [20408] to 0.21 to work around a race condition in the scheduler that can cause programs to be incorrectly marked as rsNotListed. Refs #6465

Note: See TracTickets for help on using tickets.