Patch to remove invalid "NotListed" tags

[cizek@…]

If I go into the Program Guide and select multiple programs to record (Single Record), often a few will be tagged "NotListed?". To get the recording to start, I have to go to the "Previously Recorded" screen, highlight the "N" flagged recordings, and select "Remove This Episode From The List". This fixes the problem and starts the recording.

I don't know why this happens -- I think it's a race condition between when the recordings are selected on the frontend, and when the scheduler performs the actual scheduling on the backend. The easiest way to duplicate it is to go into the Program Guide and quickly hit "R" on a bunch of programs.

The attached patch adds logic in Scheduler::UpdateMatches?(recordid) to remove the invalid record for the specified recordid. This fixes the problem for me.

This patch is against 0.21-fixes, but I've had same problem with trunk.

-Bill

[gigem]

Replying to cizek@rcn.com:

I don't know why this happens -- I think it's a race condition between when the recordings are selected on the frontend, and when the scheduler performs the actual scheduling on the backend.

Yes, it's a race condition. It can occur when a new recording rule is added while the scheduler is already running. Coincidentally, I was going to test my own fix for this very problem this afternoon. I wound up going to help a friend with some other stuff instead, though, so it will be tomorrow before I commit anything. FWIW, my intended fix is similar to yours in that it ignores old rsNotListed status, but does it slightly differently.

[gigem]

(In [20408]) Work around a race condition in the scheduler that can cause programs to be incorrectly marked as rsNotListed. Fixes #6465

[gigem]

(In [20409]) Backport of [20408] to 0.21 to work around a race condition in the scheduler that can cause programs to be incorrectly marked as rsNotListed. Refs #6465