Opened 10 years ago

Closed 10 years ago

#6474 closed defect (fixed)

Stops imdbpy.py from returning plots less than 10 words

Reported by: r.d.vaughan@… Owned by: Anduin Withers
Priority: minor Milestone: 0.22
Component: Plugin - MythVideo Version: unknown
Severity: medium Keywords: imdbpy.py
Cc: Ticket locked: no

Description

imdbpy.py tries to return the smallest plot it can find. Unfortunately the current implementation can return single word plots. This patch rejects any plot less than 10 words and evaluates the smallest plot by word count rather than sting length.

Even though the version is marked 0.22 it may also be applicable to 0.21

Attachments (2)

imdbpy_plot.patch (824 bytes) - added by r.d.vaughan@… 10 years ago.
Stops imdbpy.py from returning plots less than 10 words
imdbpy_plot_2.patch (1.1 KB) - added by r.d.vaughan@… 10 years ago.
Added standarization of error message to stderr instead of stdout

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by r.d.vaughan@…

Attachment: imdbpy_plot.patch added

Stops imdbpy.py from returning plots less than 10 words

comment:1 Changed 10 years ago by Anduin Withers

Component: Contributed Scripts & AppsPlugin - MythVideo
Owner: changed from Isaac Richards to Anduin Withers
Status: newassigned

Changed 10 years ago by r.d.vaughan@…

Attachment: imdbpy_plot_2.patch added

Added standarization of error message to stderr instead of stdout

comment:2 Changed 10 years ago by r.d.vaughan@…

An addition to the patch for plot:

Imdbpy.py has been changed to send error messages to stderr instead of stdout. Any script that uses imdbpy.py can mistaken an error message for output. With this patch imdbpy.py will be consistent with tmdb.pl and ttvdb.py in separating output (stdout) and error messages (stderr).

This patch replaces the previous patch.

comment:3 Changed 10 years ago by Rob Smith

Resolution: fixed
Status: assignedclosed

(In [21052]) Fixes #6474, this update the imdbpy.py script to only return plots with more then 10 words, and updates the stderr handling for errors

Note: See TracTickets for help on using tickets.