Opened 10 years ago

Closed 10 years ago

#6536 closed defect (fixed)

Segfault in MythWeather

Reported by: Marc Alban <marcalban@…> Owned by: Isaac Richards
Priority: minor Milestone: 0.22
Component: Plugin - MythWeather Version: head
Severity: medium Keywords: segfault
Cc: Ticket locked: no

Description

1) Enter the MythWeather? screen. 2) Press 'MENU'. 3) While the busy dialog is showing press 'ESC'.

The escape key press is not being handled by the busy dialog and is causing the the underlying weather dialog to deallocate while the source manager is still processing.

Attached is a backtrace and a patch which adds an optional parameter to the busy and progress dialogs to make them modal. This will ensure that the processing has completed before deallocating.

Attachments (6)

mythweather.backtrace (17.6 KB) - added by Marc Alban <marcalban@…> 10 years ago.
backtrace
mythweather_fix.patch (4.7 KB) - added by Marc Alban <marcalban@…> 10 years ago.
patch to fix seg fault in MythWeather?
mythweather_fix.2.patch (1.0 KB) - added by Marc Alban <marcalban@…> 10 years ago.
Alternate patch to fix segfault in MythWeather?.
mythweather_fix.3.patch (1.0 KB) - added by Marc Alban <marcalban@…> 10 years ago.
Updating patch to trunk.
mythweather.2.backtrace (2.4 KB) - added by Marc Alban <marcalban@…> 10 years ago.
Backtrace of segfault in the MythWeather? screen setup window.
mythweather_fix.4.patch (3.2 KB) - added by Marc Alban <marcalban@…> 10 years ago.
An updated patch to fix both segfaults.

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by Marc Alban <marcalban@…>

Attachment: mythweather.backtrace added

backtrace

Changed 10 years ago by Marc Alban <marcalban@…>

Attachment: mythweather_fix.patch added

patch to fix seg fault in MythWeather?

comment:1 Changed 10 years ago by danielk

Type: patchdefect

We don't want modal dialog handling with MythUI so the patch is not useful, but the backtrace is.

Changed 10 years ago by Marc Alban <marcalban@…>

Attachment: mythweather_fix.2.patch added

Alternate patch to fix segfault in MythWeather?.

Changed 10 years ago by Marc Alban <marcalban@…>

Attachment: mythweather_fix.3.patch added

Updating patch to trunk.

comment:2 Changed 10 years ago by Marc Alban <marcalban@…>

I found another segfault in the screen setup window.

To reproduce:

  • Enter MythWeather? screen setup window
  • Select an existing screen on the right side
  • Press 'Enter'
  • Press 'Esc'

Changed 10 years ago by Marc Alban <marcalban@…>

Attachment: mythweather.2.backtrace added

Backtrace of segfault in the MythWeather? screen setup window.

Changed 10 years ago by Marc Alban <marcalban@…>

Attachment: mythweather_fix.4.patch added

An updated patch to fix both segfaults.

comment:3 Changed 10 years ago by paulh

(In [21104]) Fix a segfault in MythWeather?'s setup screen when escaping out of the popup menu. Patch from Marc Alban. Refs #6536.

comment:4 Changed 10 years ago by paulh

Resolution: fixed
Status: newclosed

(In [21456]) Ignore Escape in the busy and progress dialogs. Fixes #6536.

Note: See TracTickets for help on using tickets.