Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#6560 closed patch (fixed)

Segfault in MediaMonitor::SetCDSpeed due to [20226]

Reported by: Jeff Lu <jll544@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: MythTV - General Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

[20226] creates MythCDROM *cd but doesn't check for validity before calling setSpeed. MythCDROM::get returns NULL on unimplemented platforms, resulting in segfault here. Patch checks (cd != NULL)

Attachments (1)

mythmediamon.patch (538 bytes) - added by Jeff Lu <jll544@…> 11 years ago.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by Jeff Lu <jll544@…>

Attachment: mythmediamon.patch added

comment:1 Changed 11 years ago by Nigel

(In [20591]) Logic error in setSpeed(). Thanks Jeff. Refs #6560.

comment:2 Changed 11 years ago by Nigel

Resolution: fixed
Status: newclosed

(In [20593]) Logic error in setSpeed(). Thanks Jeff. Closes #6560. I'm curious why a CDROM object could not be created, but I guess if a bad /dev path was entered in a plugin?

comment:3 Changed 11 years ago by Jeff Lu <jll544@…>

I ran into this while trying to play a DVD in win32, where MythCDROM hasn't been implemented and apparently isn't needed for DVD.

BTW, looking over the changeset, I believe there should be a return inside the "if (cd)" section, so that the new verbose outputs only on error.

Note: See TracTickets for help on using tickets.