Opened 11 years ago

Closed 11 years ago

#6627 closed patch (fixed)

convert mythgame to mythui

Reported by: Mike Rice <mikerice1969@…> Owned by: greg
Priority: minor Milestone: unknown
Component: Plugin - MythGame Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The attached patch updates mythgame to use libmythui.

With a small exception for searching I believe all the old functionality still works. For searching I used the mythui MythSearchDialog? which is nicer since it displays a list box of the matches. This box will now popup when either INCSEARCH or INCSEARCHNEXT is pushed. To support a SEARCHNEXT I think either a new dialog would be needed or some modifications to MythSearchDialog? which can be a later exercise.

In addition to a basic default and default-wide game-ui.xml I added one for Terra that looks roughly as you might expect but likely needs tweaking by the Terra designer. I also added the missing MythSearchDialog? to Terra.

Used an HTML screen for game details instead of trying to squish them into a dialog.

gameui.cpp and gameui.h replace gametree.h and gametree.cpp which can be removed.

Problems or issues... let me know.

Attachments (5)

mythgame_to_mythui.patch (50.1 KB) - added by Mike Rice <mikerice1969@…> 11 years ago.
mythgame to mythui patch
mythgame.fanartboxart.diff (30.9 KB) - added by robert.mcnamara@… 11 years ago.
Adds Fanart and boxart to MythGame?, includes previous patch
mythgame.fanartboxart.2.diff (53.2 KB) - added by robert.mcnamara@… 11 years ago.
Whoops, missed a couple svn adds
mythgame.fanartboxart3.diff (53.3 KB) - added by robert.mcnamara@… 11 years ago.
Fix a bug in image loading
mythgame_to_mythui2.patch (87.4 KB) - added by Mike Rice <mikerice1969@…> 11 years ago.
added mythui screens for details and edit, includes earlier changes and art changes

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by Mike Rice <mikerice1969@…>

Attachment: mythgame_to_mythui.patch added

mythgame to mythui patch

comment:1 Changed 11 years ago by robert.mcnamara@…

I have tested this patch (as well as themed it for Graphite) and found it to work nicely. Personally I would prefer a popup identical to the MythVideo? Gallery Info popup rather than HTML, but I'm not doing the work so I'll leave it at that. :) I also noticed you didn't port the ROM Edit screen to MythUI. This would probably work nicely as a popup as well.

All in all, nice work! I'm sure some of our MythUI gurus appreciate seeing someone take an interest. Thanks! If this makes it in with enough margin before .22, I'll probably patch to add boxart and fanart metadata. Also, if the ROM edit screen gets MythUI'd it could/should use the same File Browser as used in MythVideo?.

Changed 11 years ago by robert.mcnamara@…

Attachment: mythgame.fanartboxart.diff added

Adds Fanart and boxart to MythGame?, includes previous patch

comment:2 Changed 11 years ago by robert.mcnamara@…

Hi Mike,

Hope you can forgive a tiny addition to your patch-- Spoke to greg about the patch and let him know I wanted to add fanart and box art to MythGame?. I was going to hold off until this was applied, but then got carried away and added it to the existing patch. Also modified all the above themes for same. Example of effect this adds are here:

http://www.fecitfacta.com/mythgameplus.png http://www.fecitfacta.com/mythgameplus2.png

Changed 11 years ago by robert.mcnamara@…

Whoops, missed a couple svn adds

Changed 11 years ago by robert.mcnamara@…

Attachment: mythgame.fanartboxart3.diff added

Fix a bug in image loading

Changed 11 years ago by Mike Rice <mikerice1969@…>

Attachment: mythgame_to_mythui2.patch added

added mythui screens for details and edit, includes earlier changes and art changes

comment:3 Changed 11 years ago by Mike Rice <mikerice1969@…>

New patch contains all the previous changes plus implementation of two new MythUI screens for "Show Info" and "Edit" as suggested by Robert. Please test if interested.

comment:4 Changed 11 years ago by Isaac Richards

Resolution: fixed
Status: newclosed

(In [20780]) MythGame? mythui port, from Mike Rice

Fixes #6627

Note: See TracTickets for help on using tickets.