Opened 14 years ago

Closed 14 years ago

#663 closed patch (wontfix)

Tidy up DVB card setup

Reported by: John Pullan <john.pullan@…> Owned by: danielk
Priority: minor Milestone: 0.19
Component: mythtv Version: head
Severity: medium Keywords: DVB setup
Cc: Ticket locked: no

Description

I couldn't read the DVB card setup page. So, the attached patch :

disables Disqec button non QSPK DVB cards

move (msecs) into the help text for the timeout vales so the controls fit on screen.

It should be noted that the help text could do with being a bit shorter :)

Attachments (2)

videosouce.patch (2.0 KB) - added by John Pullan <john.pullan@…> 14 years ago.
videosource.patch (1.1 KB) - added by John Pullan <john.pullan@…> 14 years ago.

Download all attachments as: .zip

Change History (9)

Changed 14 years ago by John Pullan <john.pullan@…>

Attachment: videosouce.patch added

comment:1 Changed 14 years ago by danielk

Resolution: fixed
Status: newclosed

(In [7898]) Fixes #663.

I didn't use the patch but tried to address the concerns of overly verbose help text, and cramped layout. I also brought some consistency to the "DiSEqC" wacky mixed case string.

comment:2 Changed 14 years ago by john.pullan@…

Daniel, I'm a bit concerned you've missed the main point of the patch :) The labels for the two spin boxes were/are too long (didn't fit at all well). I'll Test it tonight when I get home and let you know.

comment:3 Changed 14 years ago by John Pullan <john.pullan@…>

Resolution: fixed
Status: closedreopened

I was wrong it looks fine, apart from the minor addendum of the DiSEqC button being active for non QPSK card types. (patch attached)

Changed 14 years ago by John Pullan <john.pullan@…>

Attachment: videosource.patch added

comment:4 Changed 14 years ago by danielk

Milestone: 0.19
Version: head

I put the two spinboxes on seperate lines so the label could still show the units.

I'm not sure if we wan't to disable DiSEqC just based on the modulation type.

Isn't there some way we can query whether the device is DiSEqC capable?

Partially my concern is for the pcHDTV HD-2000. It has two inputs, but the DVB API only supports multiple inputs via DiSEqC. So unless the DVB API is changed, a card like this can only be supported by emulating a DiSEqC device in the driver. (Yes, the DVB API is a mess on every level and could use a complete rewrite, but I can only fight so many windmills.)

comment:5 Changed 14 years ago by John Pullan <john.pullan@…>

I hadn't even considered that. I assumed it was only sat stuff which needed DiSEqC. I've certainly never heard of dvb-T/C ATSC needing it but that could just be my ignorance :)

comment:6 Changed 14 years ago by danielk

I'm going to close this for now; I'll look at the drivers and make it right, whatever that might be, after 0.19.

comment:7 Changed 14 years ago by danielk

Resolution: wontfix
Status: reopenedclosed
Note: See TracTickets for help on using tickets.