Opened 10 years ago

Closed 10 years ago

#6645 closed defect (invalid)

configure script && libavcodec.pro handle latm_parser option incorrect

Reported by: peter.brouwer@… Owned by: Isaac Richards
Priority: major Milestone: 0.21.1
Component: MythTV - General Version: 0.21-fixes
Severity: medium Keywords: latm_parser not found
Cc: Ticket locked: no

Description

From Script libavcodec.pro

--- contains( CONFIG_LIBFAAD, yes ) { SOURCES *= libfaad.c latmaac.c }


So latmaac.c is only pulled in if CONFIG_LIBFAAD is set However when the configure script sets the following in mythconfig.h #define CONFIG_LATM_PARSER 1 #define ENABLE_LATM_PARSER 1

The latm c source module is not compiled.

Change History (3)

comment:1 Changed 10 years ago by peter.brouwer@…

<PRE> From Script libavcodec.pro

--- contains( CONFIG_LIBFAAD, yes ) { SOURCES *= libfaad.c latmaac.c }

So latmaac.c is only pulled in if CONFIG_LIBFAAD is set <PRE> However when the configure script sets the following in mythconfig.h

#define CONFIG_LATM_PARSER 1 #define ENABLE_LATM_PARSER 1

and make.mak

CONFIG_LATM_PARSER=yes

without setting CONFIG_LIBFAAD

The latm c source module is not compiled, but an entry is created in allcodecs.c for latmaac.c, latm_parser, resulting in a missing latm_parser in the middle of the compilation process.

When just setting CONFIG_LATM_PARSE I get unresolved labels from latmaac.o when the library containing latmaac.o is used to create an executable </PRE>

comment:2 Changed 10 years ago by robert.mcnamara@…

Myth .21 (and .22) have no LATM support whatsoever. The text you are quoting does not appear in Myth's source. Sounds like you have patches applied.

comment:3 Changed 10 years ago by danielk

Resolution: invalid
Status: newclosed
Note: See TracTickets for help on using tickets.