Opened 14 years ago

Closed 14 years ago

#666 closed enhancement (fixed)

Add subtitle to defaultosd theme

Reported by: gtgj@… Owned by: danielk
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Here is a patch to add the program subtitle to the "description" field of the defaultosd theme. It seems from OSD::SetInfoText? (now unused) that this was the original intention.

Attachments (1)

defaultosd_subtitle-r7892.diff (550 bytes) - added by gtgj@… 14 years ago.

Download all attachments as: .zip

Change History (7)

Changed 14 years ago by gtgj@…

comment:1 Changed 14 years ago by anonymous

Milestone: 0.20
Owner: changed from Isaac Richards to danielk
Version: head

comment:2 Changed 14 years ago by danielk

what does this do?

I didn't see any change in the program info box.

comment:3 Changed 14 years ago by gtgj@…

It should have added the subtitle before the description in the "description" box of the defaultosd theme -- if the program has a subtitle. Did you test on a program that has one?

comment:4 Changed 14 years ago by danielk

That's what I thought it should do, but it didn't work for me. I tried it with a ATSC program that had closed captions.

Does this only work with subtitles and not closed captions?

comment:5 Changed 14 years ago by anonymous

Subtitle, as in program data - generally the name of the episode, not captioning.

comment:6 Changed 14 years ago by cpinkham

Resolution: fixed
Status: newclosed

(In [8019]) Close #666 by applying patch from gtgj. Displays missing %SUBTITLE% on program_info box in defaultosd.

Note: See TracTickets for help on using tickets.