Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#6681 closed patch (Unverified)

Switching between Video and TV over PiP Video always starts at latest Bookmark

Reported by: Frank Sagurna <fgunni@…> Owned by: Shane Shrybman
Priority: minor Milestone: unknown
Component: MythTV - Video Playback Version: Unspecified
Severity: low Keywords:
Cc: Ticket locked: no


Steps to Reproduce:

  1. Start a Video from your recordings
  2. Press "V" for PiP.
  3. switch to TV
  4. Go back to Video

Result: Video starts from last bookmark, or if there is none, from the beginning. Also Pausing is not possible with PiP functionality, but that maybe a feature.

Attachments (1)

6681_move_bookmark_seek_for_PxPSwap.diff (1.5 KB) - added by Shane Shrybman 11 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by Shane Shrybman

Component: MythTV - GeneralMythTV - Video Playback
Milestone: 0.230.22
Owner: changed from Isaac Richards to Shane Shrybman
Status: newaccepted
Version: unknownhead

comment:2 Changed 11 years ago by shane

(In [20777]) Refs #6681. Fix restoring of file position after PiP/PBP Swap.

Fix a race setting the fftime variable by moving SetPlaying?(true) after fftime is initially set in NVP::StartPlaying?().

There is still a known problem with racing with the fastforward to the initial bookmark. Mitigate that in a separate patch.

comment:3 Changed 11 years ago by Shane Shrybman

Status: acceptedstarted
Type: defectpatch

The attached patch further mitigates the race condition on fftime when a bookmark is set and swapping PiPs?/PBPs.

It has been working well here but is a bit risky due to being in the main NVP::StartPlaying?() path. So, it needs lengthy testing before committing.

Changed 11 years ago by Shane Shrybman

comment:4 Changed 11 years ago by Stuart Auchterlonie

Milestone: 0.220.24

Bumping open 0.22 milestone tickets to 0.24

comment:5 Changed 10 years ago by robertm

Status: startedinfoneeded

Not sure if this is still relevant after the MythUI OSD conversion. Can we get a test against current trunk? If still present, old patch is undoubtedly no longer applicable.

comment:6 Changed 10 years ago by stuartm

Resolution: Unverified
Status: infoneededclosed

Shane if you happen to read this and think the patch should still apply then please re-open with an updated patch.

comment:7 Changed 10 years ago by stuartm

Milestone: 0.24unknown
Version: headUnspecified
Note: See TracTickets for help on using tickets.