Opened 10 years ago

Closed 10 years ago

#6694 closed defect (fixed)

portability #defines after ffmpeg sync

Reported by: anonymous Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: MythTV - General Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Patch attached for a couple defines still needed in RingBuffer?.cpp and ThreadedFileWriter?.cpp after [20813]. Thanks!

Attachments (3)

r20819_defines.patch (854 bytes) - added by anonymous 10 years ago.
color_h.patch (748 bytes) - added by anonymous 10 years ago.
Still having problems on the filter... setting these pointers to static fixes it
color_h_alternate.patch (2.7 KB) - added by anonymous 10 years ago.
Alternate way of fixing multiple pointer definitions, using extern

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by anonymous

Attachment: r20819_defines.patch added

Changed 10 years ago by anonymous

Attachment: color_h.patch added

Still having problems on the filter... setting these pointers to static fixes it

Changed 10 years ago by anonymous

Attachment: color_h_alternate.patch added

Alternate way of fixing multiple pointer definitions, using extern

comment:1 Changed 10 years ago by anonymous

More details for this ticket (sorry, should have been in the description):

The first patch defines POSIX_FADV_SEQUENTIAL when !HAVE_POSIX_FADVISE. (also SYNC_FILE_RANGE_WRITE, but that was committed as a different ticket).

Either of the second and third patches will correct the multiple pointer definitions in greedyhdeint (two ways of doing it - take your pick). Currently, color.c and filter_greedyhdeint.c both define the same pointers (by including color.h). Not all versions of gcc resolve this conflict automatically.

Fix the problem either by declaring the pointers as static in color.h (color_h.patch), or by moving the real declarations into color.c and declaring them extern in filter_greedyhdeint.c (color_h_alternate.patch).

comment:2 Changed 10 years ago by Janne Grunau

Resolution: fixed
Status: newclosed

(In [20837]) Fix greedydeint yuv conversion function pointers. Fixes #6694

Note: See TracTickets for help on using tickets.