Opened 15 years ago
Closed 15 years ago
#6694 closed defect (fixed)
portability #defines after ffmpeg sync
| Reported by: | anonymous | Owned by: | Isaac Richards |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | MythTV - General | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Patch attached for a couple defines still needed in RingBuffer?.cpp and ThreadedFileWriter?.cpp after [20813]. Thanks!
Attachments (3)
Change History (5)
Changed 15 years ago by
| Attachment: | r20819_defines.patch added |
|---|
Changed 15 years ago by
| Attachment: | color_h.patch added |
|---|
Changed 15 years ago by
| Attachment: | color_h_alternate.patch added |
|---|
Alternate way of fixing multiple pointer definitions, using extern
comment:1 Changed 15 years ago by
More details for this ticket (sorry, should have been in the description):
The first patch defines POSIX_FADV_SEQUENTIAL when !HAVE_POSIX_FADVISE. (also SYNC_FILE_RANGE_WRITE, but that was committed as a different ticket).
Either of the second and third patches will correct the multiple pointer definitions in greedyhdeint (two ways of doing it - take your pick). Currently, color.c and filter_greedyhdeint.c both define the same pointers (by including color.h). Not all versions of gcc resolve this conflict automatically.
Fix the problem either by declaring the pointers as static in color.h (color_h.patch), or by moving the real declarations into color.c and declaring them extern in filter_greedyhdeint.c (color_h_alternate.patch).
Still having problems on the filter... setting these pointers to static fixes it