Opened 10 years ago

Closed 10 years ago

#6700 closed defect (fixed)

mythweb doesn't show thumbnails for slave backends

Reported by: inorkuo@… Owned by: xris
Priority: minor Milestone: unknown
Component: Plugin - MythWeb Version: head
Severity: low Keywords: mythweb thumbnails slave backends
Cc: Ticket locked: no

Description

mythweb only shows thumbnails in the recorded programs page for recordings done by the master backend. recordings done by slave backends are missing their thumbnails.

Attachments (4)

mythweb-6700-use_hostname_for_preview_pixmaps.patch (2.7 KB) - added by sphery <mtdean@…> 10 years ago.
mythweb-6700-resolve_hostname_in_MythBackend_find.patch (1019 bytes) - added by sphery <mtdean@…> 10 years ago.
Adds hostname->IP address resolution to MythBackend::find() -- apply after mythweb-6700-use_hostname_for_preview_pixmaps.patch
mythweb-6700-add_ip_address_to_MythBackend_class.patch (1.7 KB) - added by sphery <mtdean@…> 10 years ago.
Alternate approach for IP address resolution. Replaces mythweb-6700-resolve_hostname_in_MythBackend_find.patch .
mythweb-6700-add_ip_address_to_MythBackend_class.2.patch (2.4 KB) - added by sphery <mtdean@…> 10 years ago.
Updated patch. Better handles defaults.

Download all attachments as: .zip

Change History (12)

Changed 10 years ago by sphery <mtdean@…>

comment:1 Changed 10 years ago by sphery <mtdean@…>

The attached patch requests the preview pixmap from the host associated with the recording. It seems to work, though as I'm not a PHP coder, it may just be a hack that works by accident.

comment:2 in reply to:  1 Changed 10 years ago by Inor Kuo <inorkuo@…>

Replying to sphery <mtdean@thirdcontact.com>:

The attached patch requests the preview pixmap from the host associated with the recording. It seems to work, though as I'm not a PHP coder, it may just be a hack that works by accident.

i applied the patch for the two files and it does not seem to make a difference.

Changed 10 years ago by sphery <mtdean@…>

Adds hostname->IP address resolution to MythBackend::find() -- apply after mythweb-6700-use_hostname_for_preview_pixmaps.patch

comment:3 Changed 10 years ago by sphery <mtdean@…>

Added another patch. MythBackend::find() lacked hostname->IP address resolution. mythweb-6700-resolve_hostname_in_MythBackend_find.patch adds the capability, which is required for mythweb-6700-use_hostname_for_preview_pixmaps.patch to work. Both patches should be applied.

comment:4 Changed 10 years ago by Inor Kuo <inorkuo@…>

it works on my end. thanks sphery.

Changed 10 years ago by sphery <mtdean@…>

Alternate approach for IP address resolution. Replaces mythweb-6700-resolve_hostname_in_MythBackend_find.patch .

Changed 10 years ago by sphery <mtdean@…>

Updated patch. Better handles defaults.

comment:5 Changed 10 years ago by Inor Kuo <inorkuo@…>

still works.

comment:6 Changed 10 years ago by sphery <mtdean@…>

For the committer, the 2 patches that should be fixed up for committing are: mythweb-6700-use_hostname_for_preview_pixmaps.patch and mythweb-6700-add_ip_address_to_MythBackend_class.2.patch .

comment:7 Changed 10 years ago by Rob Smith

(In [21048]) Re #6700, this updates the backend module to support non-dns hostnames and some fixes to other incorrectly set defaults

comment:8 Changed 10 years ago by Rob Smith

Resolution: fixed
Status: newclosed

(In [21049]) Fixes #6700, this allows pixmaps to be generated from slave backends, thanks Mr. Dean!

Note: See TracTickets for help on using tickets.