Opened 11 years ago

Closed 11 years ago

#6712 closed patch (fixed)

Small MythGame MythUI port fixes

Reported by: robert.mcnamara@… Owned by: greg
Priority: trivial Milestone: unknown
Component: Plugin - MythGame Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

This patch corrects a couple of small issues with the code, and is fairly minor. fixes one broken binding on a DB query, makes one setting name make sense in english, and removes the old screenshot handling code.

Also removes the now-redundant setting for Game Handler Screenshots (as this is now controlled by the global screenshot dir setting).

Attachments (4)

MythGameFixes.diff (4.5 KB) - added by robert.mcnamara@… 11 years ago.
Patch as described above.
MythGameFixes.2.diff (5.8 KB) - added by robert.mcnamara@… 11 years ago.
Adds one more small fix
MythGameFixes.3.diff (5.8 KB) - added by robert.mcnamara@… 11 years ago.
Even more chopping. Supercedes previous.
mythgamefixes.diff (6.0 KB) - added by robert.mcnamara@… 11 years ago.
Accounts for latest changes

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by robert.mcnamara@…

Attachment: MythGameFixes.diff added

Patch as described above.

Changed 11 years ago by robert.mcnamara@…

Attachment: MythGameFixes.2.diff added

Adds one more small fix

comment:1 Changed 11 years ago by robert.mcnamara@…

Another small fix added. Removes the image display timer. Not entirely certain why it was there in the first place, but this removes the 330ms timer run before displaying all the images. Makes the display much more snappy.

Changed 11 years ago by robert.mcnamara@…

Attachment: MythGameFixes.3.diff added

Even more chopping. Supercedes previous.

comment:2 Changed 11 years ago by jochen

Timer...

I think the timer was there because when you wanted to scroll through the list is the old version, it was not possible to hold down a key to scroll, because then everytime a imige was loaded and so the scrolling was verry slow!

Changed 11 years ago by robert.mcnamara@…

Attachment: mythgamefixes.diff added

Accounts for latest changes

comment:3 Changed 11 years ago by greg

Resolution: fixed
Status: newclosed

(In [21122])

#closes #6712. Corrents some broken SQL bindings and remotes

some old unused timers. Also inserts screenshot info if it finds them when doing the game scan.

Note: See TracTickets for help on using tickets.