Opened 11 years ago

Closed 11 years ago

#6758 closed defect (fixed)

Remove cache_url from Weather templates

Reported by: Joe Ripley <vitaminjoe@…> Owned by: xris
Priority: minor Milestone: unknown
Component: Plugin - MythWeb Version: unknown
Severity: low Keywords: mythweb, weather
Cc: Rob Smith Ticket locked: no

Description

Changeset 19707 removed the 'cache_url' variable. The following patch hard-codes the default location if the 'data' URL in the default template files.

This fixes the Animated Map and Static Map screens.

Attachments (2)

6758.diff (1.7 KB) - added by Joe Ripley <vitaminjoe@…> 11 years ago.
Removes 'cache_url' from animated and static map templates
6758.2.diff (1.7 KB) - added by Joe Ripley <vitaminjoe@…> 11 years ago.
Revised patch to make data directory relative instead of absolute

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by Joe Ripley <vitaminjoe@…>

Attachment: 6758.diff added

Removes 'cache_url' from animated and static map templates

comment:1 Changed 11 years ago by knight@…

Hi Joe!

Are you sure this will work if mythweb is not installed in the server root?

Switching from cache_dir to cache_url in ticket 5171 (http://svn.mythtv.org/trac/ticket/5171) was done for this reason and I think substituting cache_url by only data will cause the problem we had back then (I will have to test as soon as I have a chance...).

If "root" still exist you might with to concat it to data...

Have a nice day!

Nick

comment:2 Changed 11 years ago by anonymous

Nick,

You're probably right... I just fixed it for myself and assumed everyone else installs MythWeb in the server root. :) Sorry about that...

So, I guess we need to re-define cache_url:

define('cache_url', root.data.'/');

Thanks!

-- Joe Ripley vitaminjoe@…

Changed 11 years ago by Joe Ripley <vitaminjoe@…>

Attachment: 6758.2.diff added

Revised patch to make data directory relative instead of absolute

comment:3 Changed 11 years ago by Joe Ripley <vitaminjoe@…>

After taking a closer look, the 'data' directory is static... it doesn't seem to have a definition. So, I just revised the patch to make the reference to 'data/' instead of '/data/'.

Should work for everyone. :)

Let me know if it doesn't...

-- Joe Ripley vitaminjoe@…

comment:4 Changed 11 years ago by Joe Ripley <vitaminjoe@…>

This (as well as #6757) should have its milestone set to 0.22. This patch applies to trunk.

-- Joe Ripley vitaminjoe@…

comment:5 Changed 11 years ago by Rob Smith

Resolution: fixed
Status: newclosed

(In [21795]) Fixes #6757, Fixes #6758, This fixes mythweather to work with current trunk

Note: See TracTickets for help on using tickets.