Opened 10 years ago

Closed 10 years ago

#6786 closed patch (fixed)

mythtvosd/udpnotify stops working after watching the first show

Reported by: doug@… Owned by: stuartm
Priority: minor Milestone: 0.22
Component: MythTV - General Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Hi All,

UDPnotify seems to stop working after watching the first show. The steps to reproduce are:

  1. start mythfrontend
  2. watch a program
  3. send a udp message (e.g. mythtvosd --template=cid) to confirm it works
  4. exit the show (not mythfrontend)
  5. start the show again
  6. attempt to send a udp message again (this step fails)

I think the issue is that udpnotify->deleteLater() is never called when tv_play.cpp shuts down. This means that the socket doesn't get closed so future udp messages get lost. Attached is a patch to make sure that this method is called in the TV deconstructor. I'm not sure if this is the best place for it but it worked for me.

Thanks! Doug

Attachments (1)

osd.patch (427 bytes) - added by doug@… 10 years ago.
Patch to close the udpnotify socket when user exits from tv

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by doug@…

Attachment: osd.patch added

Patch to close the udpnotify socket when user exits from tv

comment:1 Changed 10 years ago by paulh

Priority: majorminor
Type: defectpatch
Version: unknownhead

comment:2 Changed 10 years ago by stuartm

Milestone: unknown0.22

comment:3 Changed 10 years ago by stuartm

Owner: changed from Isaac Richards to stuartm
Status: newaccepted

comment:4 Changed 10 years ago by stuartm

This is related to TeardownPlayer?() not being called when exiting playback, which itself causes leaks and other problems. Someone was looking at this issue recently, but I can't remember who.

comment:5 Changed 10 years ago by stuartm

Refs #6836

comment:6 Changed 10 years ago by markk

Resolution: fixed
Status: acceptedclosed

(In [22119]) Close the UDP socket when exiting video playback. Closes #6786.

Note: See TracTickets for help on using tickets.