Opened 15 years ago
Closed 14 years ago
#6802 closed defect (fixed)
MythMusic database creation contains invalid instructions making updates fail
Reported by: | Owned by: | Rob Smith | |
---|---|---|---|
Priority: | trivial | Milestone: | unknown |
Component: | Plugin - MythMusic | Version: | head |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
The dbcheck.cpp file for the MythMusic plugin contains invalid statements making database upgrades fail at version 1005 as in the 1006 (and some more along the line) contain create staments with fields of type TEXT with a default value which is not supported as described in http://dev.mysql.com/doc/refman/5.1/en/blob.html:
"In most respects, you can regard a BLOB column as a VARBINARY column that can be as large as you like. Similarly, you can regard a TEXT column as a VARCHAR column. BLOB and TEXT differ from VARBINARY and VARCHAR in the following ways:
- For indexes on BLOB and TEXT columns, you must specify an index prefix length. For CHAR and VARCHAR, a prefix length is optional. See Section 7.4.2, “Column Indexes”.
- BLOB and TEXT columns cannot have DEFAULT values."
Please find attached a patch to fix this.
Attachments (2)
Change History (5)
Changed 15 years ago by
Attachment: | mythplugins-mythmusic-mythmusic-dbcheck_cpp.patch added |
---|
Changed 15 years ago by
Attachment: | mythplugins-mythmusic-mythmusic-dbcheck_cpp-new.patch added |
---|
Oops, the patch removed the NOT NULL specifier which is allowed, this is an updated patch (new name as it was failing to upload due to not having delete permissions to overwrite existing patch)
comment:1 Changed 15 years ago by
Milestone: | 0.22 → unknown |
---|---|
Priority: | major → trivial |
Severity: | medium → low |
comment:2 Changed 15 years ago by
Owner: | changed from stuartm to Rob Smith |
---|---|
Status: | new → accepted |
Patch removing default value for fields with TEXT type